From: Jean Delvare <khali@linux-fr.org>
To: Christopher Hoover <ch@murgatroid.com>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
kernel-janitors@lists.osdl.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Clean up magic numbers in i2c_parport.h
Date: Thu, 23 Mar 2006 20:56:17 +0100 [thread overview]
Message-ID: <20060323205617.38e02afe.khali@linux-fr.org> (raw)
In-Reply-To: <20060323081231.D794B1EC019@garage.murgatroid.com>
Hi Christopher,
> This small patch gets rid of some magic numbers in the i2c parport
> drivers, specifically wrt the control and status handling, using the
> symbols already defined in parport.h
>
> The patch produces the same binary objects for i2c-parport.c and
> i2c-parport-simple.c as before.
> --- linux-2.6.16/drivers/i2c/busses/i2c-parport.h 2006-03-19 21:53:29.000000000 -0800
> +++ linux-2.6.16.i2c/drivers/i2c/busses/i2c-parport.h 2006-03-22 23:51:08.000000000 -0800
> (...)
> +#define LINEOP_DATA(val_, inverted_) \
> + { .val=(val_), .port = DATA, .inverted=(inverted_) }
> +
> +#define LINEOP_STATUS(val_, inverted_) \
> + { .val=(val_), .port = STAT, .inverted=(inverted_) }
> +
> +#define LINEOP_CONTROL(val_, inverted_) \
> + { .val=(val_), .port = CTRL, .inverted=(inverted_) }
> +
Beeuh. These macros don't really help. They actually make the lines
longer! I'm not taking this change, sorry.
Other than that, I am fine with your patch. Not that I really see the
benefit, but it others do, why not. Can you please respin the patch
without the additional macros?
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2006-03-23 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 8:12 [PATCH] Clean up magic numbers in i2c_parport.h Christopher Hoover
2006-03-23 19:56 ` Jean Delvare [this message]
2006-03-24 4:45 ` Christopher Hoover
2006-03-24 7:26 ` Jean Delvare
2006-03-24 17:49 ` [KJ] " Greg KH
2006-03-24 19:31 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323205617.38e02afe.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=akpm@osdl.org \
--cc=ch@murgatroid.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox