From: Nigel Cunningham <ncunningham@cyclades.com>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make libata not powerdown drivers on PM_EVENT_FREEZE.
Date: Thu, 23 Mar 2006 23:20:33 +1000 [thread overview]
Message-ID: <200603232320.39724.ncunningham@cyclades.com> (raw)
In-Reply-To: <20060323130919.GZ4285@suse.de>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
Hi.
On Thursday 23 March 2006 23:09, Jens Axboe wrote:
> On Thu, Mar 23 2006, Nigel Cunningham wrote:
> > diff -ruNp 9904-libata-freeze.patch-old/drivers/scsi/libata-scsi.c
> > 9904-libata-freeze.patch-new/drivers/scsi/libata-scsi.c ---
> > 9904-libata-freeze.patch-old/drivers/scsi/libata-scsi.c 2006-03-23
> > 21:16:22.000000000 +1000 +++
> > 9904-libata-freeze.patch-new/drivers/scsi/libata-scsi.c 2006-03-23
> > 21:24:06.000000000 +1000 @@ -419,7 +419,7 @@ int
> > ata_scsi_device_suspend(struct scsi_
> > struct ata_port *ap = (struct ata_port *) &sdev->host->hostdata[0];
> > struct ata_device *dev = &ap->device[sdev->id];
> >
> > - return ata_device_suspend(ap, dev);
> > + return ata_device_suspend(ap, dev, state);
> > }
>
> Eh this looks odd, you are forgetting to add pm_message_t state as an
> extra argument to that function.
>
> Apart from that, patch looks good. It should definitely be included
> asap.
Good catch! Fixed, will resend.
Thanks!
Nigel
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-03-23 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 11:51 [PATCH] Make libata not powerdown drivers on PM_EVENT_FREEZE Nigel Cunningham
2006-03-23 12:06 ` Andrew Morton
2006-03-22 23:26 ` Pavel Machek
2006-03-23 12:16 ` Nigel Cunningham
2006-03-23 13:09 ` Jens Axboe
2006-03-23 13:20 ` Nigel Cunningham [this message]
2006-03-23 13:22 ` Nigel Cunningham
2006-03-23 13:52 ` Jeff Garzik
2006-03-23 21:01 ` Nigel Cunningham
2006-03-23 22:45 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603232320.39724.ncunningham@cyclades.com \
--to=ncunningham@cyclades.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox