Re: [Cbe-oss-dev] [patch 02/13] powerpc: add hvc backend for rtas

Olof Johansson
2006-03-23T22:50:26Z

On Thu, Mar 23, 2006 at 11:36:19PM +0100, Arnd Bergmann wrote:
> Am Thursday 23 March 2006 22:32 schrieb Olof Johansson:
> > > +static inline int hvc_rtas_write_console(uint32_t vtermno, const char
> > > *buf, int count) +{
> > > +     int done;
> > > +
> > > +     /* if there is more than one character to be displayed, wait a bit */
> > > +     for (done = 0; done < count; done++) {
> > > +             int result;
> > > +             result = rtas_call(rtascons_put_char_token, 1, 1, NULL, buf[done]);
> > > +             if (result)
> > > +                     break;
> >
> > Why introduce a scope-local variable just to check it?
> >                 if(rtas_call(...))   would be cleaner.
>
> I don't like doing the important stuff inside of another expression,
> and I prefer conditions not to have side-effects.
> If nobody else has a strong opinion on it, I'd prefer to leave it.

Ok. It just looked silly to have the declaration/assignment/test and no
use of result outside of those three lines.

> BTW, who is the current maintainer of hvc_console? Ryan is working on
> glibc nowadays, right?

That's what I think IBM pays him to do, that's never stopped people from
maintaining other code in the past though. :-)

-Olof