From: Andrew Morton <akpm@osdl.org>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: greg@kroah.com, kaneshige.kenji@jp.fujitsu.com,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 2.6.16-mm1 1/4] PCI legacy I/O port free driver (take 6) - Changes to generic PCI code
Date: Fri, 24 Mar 2006 01:36:26 -0800 [thread overview]
Message-ID: <20060324013626.4e15082d.akpm@osdl.org> (raw)
In-Reply-To: <44238424.3080500@jp.fujitsu.com>
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> wrote:
>
> +/*
> + * This helper routine makes bar mask from the type of resource.
> + */
> +static inline int pci_select_bars(struct pci_dev *dev, unsigned long flags)
> +{
> + int i, bars = 0;
> + for (i = 0; i < PCI_NUM_RESOURCES; i++)
> + if (pci_resource_flags(dev, i) & flags)
> + bars |= (1 << i);
> + return bars;
> +}
Can we please uninline this?
next prev parent reply other threads:[~2006-03-24 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 5:26 [PATCH 2.6.16-mm1 0/4] PCI legacy I/O port free driver (take 6) Kenji Kaneshige
2006-03-24 5:31 ` [PATCH 2.6.16-mm1 1/4] PCI legacy I/O port free driver (take 6) - Changes to generic PCI code Kenji Kaneshige
2006-03-24 9:36 ` Andrew Morton [this message]
2006-03-27 5:35 ` Kenji Kaneshige
2006-03-24 5:32 ` [PATCH 2.6.16-mm1 2/4] PCI legacy I/O port free driver (take 6) - Update Documentation/pci.txt Kenji Kaneshige
2006-03-24 16:24 ` Grant Grundler
2006-03-24 5:34 ` [PATCH 2.6.16-mm1 3/4] PCI legacy I/O port free driver (take 6) - Make Intel e1000 driver legacy I/O port free Kenji Kaneshige
2006-03-24 5:36 ` [PATCH 2.6.16-mm1 4/4] PCI legacy I/O port free driver (take 6) - Make Emulex lpfc " Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324013626.4e15082d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox