From: Ashok Raj <ashok.raj@intel.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Andi Kleen <ak@suse.de>, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] Ignore MCFG if the mmconfig area isn't reserved in thee820 table
Date: Fri, 24 Mar 2006 07:22:51 -0800 [thread overview]
Message-ID: <20060324072250.A13756@unix-os.sc.intel.com> (raw)
In-Reply-To: <1143141320.3147.47.camel@laptopd505.fenrus.org>; from arjan@linux.intel.com on Thu, Mar 23, 2006 at 11:15:19AM -0800
On Thu, Mar 23, 2006 at 11:15:19AM -0800, Arjan van de Ven wrote:
>
> >
> > I'll do a new patch using this for x86_64 though, no need to make a
> > second function like this.
>
> int __init e820_mapped(unsigned long start, unsigned long end,
> unsigned type)
Why not use the same type of function like x86_64 as well instead of the newly
added is_820_mapped()? If the purpose of both functions is the same, i386 could benefit
with same style code instead of a slight variant.
--
Cheers,
Ashok Raj
- Open Source Technology Center
next prev parent reply other threads:[~2006-03-24 15:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 18:22 [patch] Ignore MCFG if the mmconfig area isn't reserved in the e820 table Arjan van de Ven
2006-03-23 17:56 ` Andi Kleen
2006-03-23 19:02 ` Arjan van de Ven
2006-03-23 19:15 ` Arjan van de Ven
2006-03-24 12:19 ` Andi Kleen
2006-03-24 13:36 ` Arjan van de Ven
2006-03-24 21:25 ` Greg KH
2006-03-24 15:22 ` Ashok Raj [this message]
2006-03-24 15:24 ` [patch] Ignore MCFG if the mmconfig area isn't reserved in thee820 table Arjan van de Ven
2006-03-24 15:39 ` Andi Kleen
2006-03-24 15:42 ` Arjan van de Ven
2006-03-24 15:48 ` Ashok Raj
2006-03-24 15:48 ` Arjan van de Ven
2006-03-24 15:48 ` Andi Kleen
2006-03-24 15:50 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324072250.A13756@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox