public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Christopher Hoover" <ch@murgatroid.com>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Clean up magic numbers in i2c_parport.h
Date: Fri, 24 Mar 2006 08:26:00 +0100	[thread overview]
Message-ID: <20060324082600.ca9f9796.khali@linux-fr.org> (raw)
In-Reply-To: <000e01c64efd$cae7f750$8401000a@fakie>

Hi Christopher,

> > Beeuh. These macros don't really help. They actually make the lines
> > longer! I'm not taking this change, sorry.
> 
> If I kill off the macros but continue to use C99 structure initializers,
> which is I believe is the proper kernel coding style today, the lines are
> going to get even longer.  Is that OK?
> 
> Or are you asking for the patch w/o macros and w/o C99 structure
> initializers?
> 
> I can/will do either.  Just let me know what is acceptable a priori.

I don't think C99 initializers are needed here, the structure is pretty
simple and is also defined in the same file, a few lines above all its
instance declarations. So I am indeed asking for a patch w/o macros and
w/o C99 structure initializers, unless someone objects.

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2006-03-24  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-23  8:12 [PATCH] Clean up magic numbers in i2c_parport.h Christopher Hoover
2006-03-23 19:56 ` Jean Delvare
2006-03-24  4:45   ` Christopher Hoover
2006-03-24  7:26     ` Jean Delvare [this message]
2006-03-24 17:49       ` [KJ] " Greg KH
2006-03-24 19:31         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060324082600.ca9f9796.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=akpm@osdl.org \
    --cc=ch@murgatroid.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox