ACPI Compile error in current git (pci.h)

ACPI Compile error in current git (pci.h)

[Nigel Cunningham]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi.

Current git produces the following compile error (x86_64 uniprocessor compile):

arch/x86_64/pci/mmconfig.c:152: error: conflicting types for ‘pci_mmcfg_init’
arch/i386/pci/pci.h:85: error: previous declaration of ‘pci_mmcfg_init’ was here
make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
make: *** [arch/x86_64/pci] Error 2

I haven't found out yet how the i386 file is getting included, but I
can say that git compiled fine last night.

Greg, I believe you're the pci guru, so I thought I'd try you too.
Apologies in advance if I've gotten it wrong.

Regards,

Nigel

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: ACPI Compile error in current git (pci.h)

[Nigel Cunningham]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

Hi again.

On Friday 24 March 2006 14:04, Nigel Cunningham wrote:
> Hi.
>
> Current git produces the following compile error (x86_64 uniprocessor
> compile):
>
> arch/x86_64/pci/mmconfig.c:152: error: conflicting types for
> ‘pci_mmcfg_init’ arch/i386/pci/pci.h:85: error: previous declaration of
> ‘pci_mmcfg_init’ was here make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
> make: *** [arch/x86_64/pci] Error 2
>
> I haven't found out yet how the i386 file is getting included, but I
> can say that git compiled fine last night.

Got the answer to this bit - it is included via the Makefile in the directory 
setting a -I flag, and the file including "pci.h".

Regards,

Nigel

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: ACPI Compile error in current git (pci.h)

[Greg KH]

On Fri, Mar 24, 2006 at 02:37:18PM +1000, Nigel Cunningham wrote:
> Hi again.
> 
> On Friday 24 March 2006 14:04, Nigel Cunningham wrote:
> > Hi.
> >
> > Current git produces the following compile error (x86_64 uniprocessor
> > compile):
> >
> > arch/x86_64/pci/mmconfig.c:152: error: conflicting types for
> > ???pci_mmcfg_init??? arch/i386/pci/pci.h:85: error: previous declaration of
> > ???pci_mmcfg_init??? was here make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
> > make: *** [arch/x86_64/pci] Error 2
> >
> > I haven't found out yet how the i386 file is getting included, but I
> > can say that git compiled fine last night.
> 
> Got the answer to this bit - it is included via the Makefile in the directory 
> setting a -I flag, and the file including "pci.h".

Does this still happen for 2.6.17-rc1?

thanks,

greg k-h

Re: ACPI Compile error in current git (pci.h)

[Nigel Cunningham]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hi Greg.

On Thursday 06 April 2006 13:50, Greg KH wrote:
> On Fri, Mar 24, 2006 at 02:37:18PM +1000, Nigel Cunningham wrote:
> > Hi again.
> >
> > On Friday 24 March 2006 14:04, Nigel Cunningham wrote:
> > > Hi.
> > >
> > > Current git produces the following compile error (x86_64 uniprocessor
> > > compile):
> > >
> > > arch/x86_64/pci/mmconfig.c:152: error: conflicting types for
> > > ???pci_mmcfg_init??? arch/i386/pci/pci.h:85: error: previous
> > > declaration of ???pci_mmcfg_init??? was here make[1]: ***
> > > [arch/x86_64/pci/mmconfig.o] Error 1 make: *** [arch/x86_64/pci] Error
> > > 2
> > >
> > > I haven't found out yet how the i386 file is getting included, but I
> > > can say that git compiled fine last night.
> >
> > Got the answer to this bit - it is included via the Makefile in the
> > directory setting a -I flag, and the file including "pci.h".
>
> Does this still happen for 2.6.17-rc1?
>
> thanks,
>
> greg k-h

No, it's fixed. I figured out the cause a little later the same day, and so 
did someone else (don't recall the name now). A patch has been merged.

Regards,

Nigel

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]