Re: 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.

Nigel Cunningham
2006-03-26T23:03:20Z

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

Hi Andi.

On Friday 24 March 2006 21:36, Andi Kleen wrote:
> On Friday 24 March 2006 12:14, Jean Delvare wrote:
> > Hi Nigel, Andi, all,
> >
> > > It looks to me like the above commit from Andi causes a compilation
> > > failure on x86_64, because it makes pci_mmcfg_init non static:
> > >
> > > arch/x86_64/pci/mmconfig.c:152: error: conflicting types for
> > > ‘pci_mmcfg_init’ arch/i386/pci/pci.h:85: error: previous declaration of
> > > ‘pci_mmcfg_init’ was here
> > > make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
> > > make: *** [arch/x86_64/pci] Error 2
> >
> > I just hit the same compilation failure. Here's a fix which works for
> > me.
>
> This was my mistake. I fixed the problem in the wrong patch. And then
> Greg submitted only the one patch. I think Andrew fixed it up by
> submitting the other (unrelated) patch which fixes this too.

Thanks for the reply. It's not in Linus' tree yet, so I think the Andrew might
still need some encouragement to merge it :)

Regards,