[2.6 patch] let x86 subarchs select SMP

[2.6 patch] let x86 subarchs select SMP

[Adrian Bunk]

The SMP question comes after the subarch question, and it does therefore 
make sense to let the SMP-only subarchs select SMP instead of depending 
on it.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 18 Mar 2006

 arch/i386/Kconfig |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-2.6.16-rc6-mm2-full/arch/i386/Kconfig.old	2006-03-18 15:10:30.000000000 +0100
+++ linux-2.6.16-rc6-mm2-full/arch/i386/Kconfig	2006-03-18 15:11:14.000000000 +0100
@@ -95,7 +95,7 @@
 
 config X86_SUMMIT
 	bool "Summit/EXA (IBM x440)"
-	depends on SMP
+	select SMP
 	help
 	  This option is needed for IBM systems that use the Summit/EXA chipset.
 	  In particular, it is needed for the x440.
@@ -104,7 +104,7 @@
 
 config X86_BIGSMP
 	bool "Support for other sub-arch SMP systems with more than 8 CPUs"
-	depends on SMP
+	select SMP
 	help
 	  This option is needed for the systems that have more than 8 CPUs
 	  and if the system is not of any sub-arch type above.
@@ -124,14 +124,14 @@
 
 config X86_GENERICARCH
        bool "Generic architecture (Summit, bigsmp, ES7000, default)"
-       depends on SMP
+       select SMP
        help
           This option compiles in the Summit, bigsmp, ES7000, default subarchitectures.
 	  It is intended for a generic binary kernel.
 
 config X86_ES7000
 	bool "Support for Unisys ES7000 IA32 series"
-	depends on SMP
+	select SMP
 	help
 	  Support for Unisys ES7000 systems.  Say 'Y' here if this kernel is
 	  supposed to run on an IA32-based Unisys ES7000 system.

Re: [2.6 patch] let x86 subarchs select SMP

[Roman Zippel]

Hi,

On Fri, 24 Mar 2006, Adrian Bunk wrote:

> The SMP question comes after the subarch question, and it does therefore 
> make sense to let the SMP-only subarchs select SMP instead of depending 
> on it.

No, it doesn't make sense. If the ordering is wrong, fix the ordering, but 
that's a silly reason to use select.

bye, Roman

[2.6 patch] i386: move SMP option above subarch selection

[Adrian Bunk]

On Fri, Mar 24, 2006 at 07:30:17PM +0100, Roman Zippel wrote:
> Hi,
> 
> On Fri, 24 Mar 2006, Adrian Bunk wrote:
> 
> > The SMP question comes after the subarch question, and it does therefore 
> > make sense to let the SMP-only subarchs select SMP instead of depending 
> > on it.
> 
> No, it doesn't make sense. If the ordering is wrong, fix the ordering, but 
> that's a silly reason to use select.

Patch below.

> bye, Roman

cu
Adrian


<--  snip  -->


Since several subarchs depend on SMP, the SMP option should be above the 
subarch selection.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 arch/i386/Kconfig |   58 +++++++++++++++++++++++-----------------------
 1 file changed, 29 insertions(+), 29 deletions(-)

--- linux-2.6.17-rc1-mm1-full/arch/i386/Kconfig.old	2006-04-07 17:04:26.000000000 +0200
+++ linux-2.6.17-rc1-mm1-full/arch/i386/Kconfig	2006-04-07 17:05:29.000000000 +0200
@@ -57,6 +57,35 @@
 
 menu "Processor type and features"
 
+config SMP
+	bool "Symmetric multi-processing support"
+	---help---
+	  This enables support for systems with more than one CPU. If you have
+	  a system with only one CPU, like most personal computers, say N. If
+	  you have a system with more than one CPU, say Y.
+
+	  If you say N here, the kernel will run on single and multiprocessor
+	  machines, but will use only one CPU of a multiprocessor machine. If
+	  you say Y here, the kernel will run on many, but not all,
+	  singleprocessor machines. On a singleprocessor machine, the kernel
+	  will run faster if you say N here.
+
+	  Note that if you say Y here and choose architecture "586" or
+	  "Pentium" under "Processor family", the kernel will not work on 486
+	  architectures. Similarly, multiprocessor kernels for the "PPro"
+	  architecture may not work on all Pentium based boards.
+
+	  People using multiprocessor machines who say Y here should also say
+	  Y to "Enhanced Real Time Clock Support", below. The "Advanced Power
+	  Management" code will be disabled if you say Y here.
+
+	  See also the <file:Documentation/smp.txt>,
+	  <file:Documentation/i386/IO-APIC.txt>,
+	  <file:Documentation/nmi_watchdog.txt> and the SMP-HOWTO available at
+	  <http://www.tldp.org/docs.html#howto>.
+
+	  If you don't know what to do here, say N.
+
 choice
 	prompt "Subarchitecture Type"
 	default X86_PC
@@ -188,35 +217,6 @@
 	depends on HPET_TIMER && RTC=y
 	default y
 
-config SMP
-	bool "Symmetric multi-processing support"
-	---help---
-	  This enables support for systems with more than one CPU. If you have
-	  a system with only one CPU, like most personal computers, say N. If
-	  you have a system with more than one CPU, say Y.
-
-	  If you say N here, the kernel will run on single and multiprocessor
-	  machines, but will use only one CPU of a multiprocessor machine. If
-	  you say Y here, the kernel will run on many, but not all,
-	  singleprocessor machines. On a singleprocessor machine, the kernel
-	  will run faster if you say N here.
-
-	  Note that if you say Y here and choose architecture "586" or
-	  "Pentium" under "Processor family", the kernel will not work on 486
-	  architectures. Similarly, multiprocessor kernels for the "PPro"
-	  architecture may not work on all Pentium based boards.
-
-	  People using multiprocessor machines who say Y here should also say
-	  Y to "Enhanced Real Time Clock Support", below. The "Advanced Power
-	  Management" code will be disabled if you say Y here.
-
-	  See also the <file:Documentation/smp.txt>,
-	  <file:Documentation/i386/IO-APIC.txt>,
-	  <file:Documentation/nmi_watchdog.txt> and the SMP-HOWTO available at
-	  <http://www.tldp.org/docs.html#howto>.
-
-	  If you don't know what to do here, say N.
-
 config NR_CPUS
 	int "Maximum number of CPUs (2-255)"
 	range 2 255

[2.6 patch] let x86 subarchs select SMP

[Adrian Bunk]

The SMP question comes after the subarch question, and it does therefore 
make sense to let the SMP-only subarchs select SMP instead of depending 
on it.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 arch/i386/Kconfig |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-2.6.16-rc6-mm2-full/arch/i386/Kconfig.old	2006-03-18 15:10:30.000000000 +0100
+++ linux-2.6.16-rc6-mm2-full/arch/i386/Kconfig	2006-03-18 15:11:14.000000000 +0100
@@ -95,7 +95,7 @@
 
 config X86_SUMMIT
 	bool "Summit/EXA (IBM x440)"
-	depends on SMP
+	select SMP
 	help
 	  This option is needed for IBM systems that use the Summit/EXA chipset.
 	  In particular, it is needed for the x440.
@@ -104,7 +104,7 @@
 
 config X86_BIGSMP
 	bool "Support for other sub-arch SMP systems with more than 8 CPUs"
-	depends on SMP
+	select SMP
 	help
 	  This option is needed for the systems that have more than 8 CPUs
 	  and if the system is not of any sub-arch type above.
@@ -124,14 +124,14 @@
 
 config X86_GENERICARCH
        bool "Generic architecture (Summit, bigsmp, ES7000, default)"
-       depends on SMP
+       select SMP
        help
           This option compiles in the Summit, bigsmp, ES7000, default subarchitectures.
 	  It is intended for a generic binary kernel.
 
 config X86_ES7000
 	bool "Support for Unisys ES7000 IA32 series"
-	depends on SMP
+	select SMP
 	help
 	  Support for Unisys ES7000 systems.  Say 'Y' here if this kernel is
 	  supposed to run on an IA32-based Unisys ES7000 system.