Re: [KJ] Re: [PATCH] Clean up magic numbers in i2c_parport.h

[Greg KH <greg@kroah.com>]

On Fri, Mar 24, 2006 at 08:26:00AM +0100, Jean Delvare wrote:
> Hi Christopher,
> 
> > > Beeuh. These macros don't really help. They actually make the lines
> > > longer! I'm not taking this change, sorry.
> > 
> > If I kill off the macros but continue to use C99 structure initializers,
> > which is I believe is the proper kernel coding style today, the lines are
> > going to get even longer.  Is that OK?
> > 
> > Or are you asking for the patch w/o macros and w/o C99 structure
> > initializers?
> > 
> > I can/will do either.  Just let me know what is acceptable a priori.
> 
> I don't think C99 initializers are needed here, the structure is pretty
> simple and is also defined in the same file, a few lines above all its
> instance declarations. So I am indeed asking for a patch w/o macros and
> w/o C99 structure initializers, unless someone objects.

You should use structure initializers whereever possible, as it makes
future changes much easier and safer (reorder the fields and things
don't break in odd ways.)  So I would encourage this kind of change.

thanks,

greg k-h