From: Dimitri Sivanich <sivanich@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu,
roe@sgi.com, steiner@sgi.com,
Christoph Lameter <clameter@sgi.com>
Subject: [PATCH] Call get_time() only when necessary in run_hrtimer_queue
Date: Fri, 24 Mar 2006 11:51:36 -0600 [thread overview]
Message-ID: <20060324175136.GA10186@sgi.com> (raw)
It seems that run_hrtimer_queue() is calling get_time() much more often
than it needs to.
With this patch, it only calls get_time() if there's a pending timer.
Following is from a profile done without the patch:
kernel ticks: 30841 1.02 %
13572 44.01 44.01 time_interpolator_get_offset
155 0.50 96.91 hrtimer_run_queues
And with the patch:
kernel ticks: 18334 0.58 %
74 0.40 97.81 hrtimer_run_queues
43 0.23 98.63 time_interpolator_get_offset
Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
Index: linux-2.6.15/kernel/hrtimer.c
===================================================================
--- linux-2.6.15.orig/kernel/hrtimer.c 2006-03-23 14:37:49.032686221 -0600
+++ linux-2.6.15/kernel/hrtimer.c 2006-03-23 14:39:10.655542086 -0600
@@ -586,12 +586,17 @@ int hrtimer_get_res(const clockid_t whic
*/
static inline void run_hrtimer_queue(struct hrtimer_base *base)
{
- ktime_t now = base->get_time();
- struct rb_node *node;
+ ktime_t now;
+ struct rb_node *node = base->first;
+
+ if (!node)
+ return;
+
+ now = base->get_time();
spin_lock_irq(&base->lock);
- while ((node = base->first)) {
+ while (node) {
struct hrtimer *timer;
int (*fn)(void *);
int restart;
@@ -620,6 +625,7 @@ static inline void run_hrtimer_queue(str
spin_lock_irq(&base->lock);
+ node = base->first;
/* Another CPU has added back the timer */
if (timer->state != HRTIMER_RUNNING)
continue;
next reply other threads:[~2006-03-24 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 17:51 Dimitri Sivanich [this message]
2006-03-24 22:28 ` [PATCH] Call get_time() only when necessary in run_hrtimer_queue Andrew Morton
2006-03-25 7:01 ` Thomas Gleixner
2006-03-28 16:51 ` Dimitri Sivanich
2006-03-28 17:39 ` Eric Dumazet
2006-03-28 17:55 ` Dimitri Sivanich
2006-03-28 19:20 ` Thomas Gleixner
2006-03-28 20:14 ` [PATCH] Call get_softirq_time() only when necessary in run_hrtimer_queue() Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324175136.GA10186@sgi.com \
--to=sivanich@sgi.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roe@sgi.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox