Re: [PATCH] Call get_time() only when necessary in run_hrtimer_queue

Thomas Gleixner
2006-03-28T19:19:49Z

On Tue, 2006-03-28 at 11:55 -0600, Dimitri Sivanich wrote:
> We could the following simpler change instead:
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
>
> Index: linux/kernel/hrtimer.c
> ===================================================================
> --- linux.orig/kernel/hrtimer.c 2006-03-28 11:46:45.279722496 -0600
> +++ linux/kernel/hrtimer.c 2006-03-28 11:51:36.722469752 -0600
> @@ -606,6 +606,9 @@ static inline void run_hrtimer_queue(str
> {
> struct rb_node *node;
>
> + if (!base->first)
> + return;
> +
> if (base->get_softirq_time)
> base->softirq_time = base->get_softirq_time();
>

Looks much better. Can you please resubmit with a proper patch
description ?

Please add: Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

tglx