From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Darren Jenkins <darrenrjenkins@gmail.com>
Subject: [2.6 patch] fix array over-run in efi.c
Date: Sat, 25 Mar 2006 12:58:53 +0100 [thread overview]
Message-ID: <20060325115853.GB4053@stusta.de> (raw)
From: Darren Jenkins <darrenrjenkins@gmail.com>
Coverity found an over-run @ line 364 of efi.c
This is due to the loop checking the size correctly, then adding a '\0'
after possibly hitting the end of the array.
The patch below just ensures the loop exits with one space left in the
array.
Compile tested.
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was sent by Darren Jenkins on:
- 08 Mar 2006
--- linux-2.6.16-rc5/arch/i386/kernel/efi.c.orig 2006-03-08 12:31:14.000000000 +1100
+++ linux-2.6.16-rc5/arch/i386/kernel/efi.c 2006-03-08 12:37:59.000000000 +1100
@@ -359,7 +359,7 @@ void __init efi_init(void)
*/
c16 = (efi_char16_t *) boot_ioremap(efi.systab->fw_vendor, 2);
if (c16) {
- for (i = 0; i < sizeof(vendor) && *c16; ++i)
+ for (i = 0; i < (sizeof(vendor) - 1) && *c16; ++i)
vendor[i] = *c16++;
vendor[i] = '\0';
} else
next reply other threads:[~2006-03-25 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-25 11:58 Adrian Bunk [this message]
2006-03-25 18:41 ` [2.6 patch] fix array over-run in efi.c Jan Engelhardt
2006-03-25 21:15 ` Adrian Bunk
2006-03-26 2:18 ` Darren Jenkins\
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060325115853.GB4053@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=darrenrjenkins@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox