From: Adrian Bunk <bunk@stusta.de>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Darren Jenkins <darrenrjenkins@gmail.com>
Subject: Re: [2.6 patch] fix array over-run in efi.c
Date: Sat, 25 Mar 2006 22:15:41 +0100 [thread overview]
Message-ID: <20060325211541.GA4053@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0603251941111.29793@yvahk01.tjqt.qr>
On Sat, Mar 25, 2006 at 07:41:56PM +0100, Jan Engelhardt wrote:
>
> >- for (i = 0; i < sizeof(vendor) && *c16; ++i)
> >+ for (i = 0; i < (sizeof(vendor) - 1) && *c16; ++i)
>
> for (i = 0; i < sizeof(vendor) - 1 && *c16; ++i)
> Should suffice.
That's irrelevant.
The important question is readability.
> Jan Engelhardt
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-03-25 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-25 11:58 [2.6 patch] fix array over-run in efi.c Adrian Bunk
2006-03-25 18:41 ` Jan Engelhardt
2006-03-25 21:15 ` Adrian Bunk [this message]
2006-03-26 2:18 ` Darren Jenkins\
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060325211541.GA4053@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=darrenrjenkins@gmail.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox