public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.16-mm1 2/3] rtc: m41t00 driver cleanup
Date: Mon, 27 Mar 2006 19:11:11 +0200	[thread overview]
Message-ID: <20060327191111.f7b057cb.khali@linux-fr.org> (raw)
In-Reply-To: <20060324012137.GD9560@mag.az.mvista.com>

Hi Mark,

> This patch does some cleanup to the m41t00 i2c/rtc driver including:
> - use BCD2BIN/BIN2BCD instead of BCD_TO_BIN/BIN_TO_BCD
> - use strlcpy instead of strncpy
> - some whitespace cleanup

Looks overall good, except:

> @@ -214,6 +208,7 @@ m41t00_detach(struct i2c_client *client)
>  
>  static struct i2c_driver m41t00_driver = {
>  	.driver = {
> +		.owner	= THIS_MODULE,
>  		.name	= M41T00_DRV_NAME,
>  	},
>  	.id		= I2C_DRIVERID_STM41T00,

i2c_add_driver sets the owner for you, so it was omitted here on
purpose.

I'll drop that change before pushing the patch to Greg, no need to
resend.

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2006-03-27 17:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <440B4B6E.8080307@sh.cvut.cz>
     [not found] ` <zt2d4LqL.1141645514.2993990.khali@localhost>
     [not found]   ` <20060307170107.GA5250@mag.az.mvista.com>
     [not found]     ` <20060318001254.GA14079@mag.az.mvista.com>
     [not found]       ` <20060323210856.f1bfd02b.khali@linux-fr.org>
     [not found]         ` <20060323203843.GA18912@mag.az.mvista.com>
2006-03-24  1:18           ` [PATCH 2.6.16-mm1 1/3] rtc: m41t00 driver should use workqueue instead of tasklet Mark A. Greer
2006-03-27 17:03             ` Jean Delvare
2006-03-28  0:22               ` Mark A. Greer
2006-03-24  1:21           ` [PATCH 2.6.16-mm1 2/3] rtc: m41t00 driver cleanup Mark A. Greer
2006-03-27 17:11             ` Jean Delvare [this message]
2006-03-27 22:35               ` Mark A. Greer
2006-03-28  0:23               ` Mark A. Greer
2006-03-24  1:24           ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-03-26 22:58             ` Andrew Morton
2006-03-27 22:34               ` Mark A. Greer
2006-03-28  0:26               ` Mark A. Greer
2006-03-28  0:51                 ` Andrew Morton
2006-03-28 12:21                   ` Jean Delvare
2006-03-28 17:15                     ` Mark A. Greer
2006-03-28 15:54                 ` Jean Delvare
2006-03-28 18:11                   ` Mark A. Greer
2006-03-28 18:30                     ` Jean Delvare
2006-03-28 23:12                       ` Mark A. Greer
2006-04-01 17:20                         ` Jean Delvare
2006-04-03 18:01                           ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060327191111.f7b057cb.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mgreer@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox