* [PATCH] x86_64: extra NODES_SHIFT definition
@ 2006-03-27 17:12 Dave Hansen
2006-03-27 17:14 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Dave Hansen @ 2006-03-27 17:12 UTC (permalink / raw)
To: ak; +Cc: linux-kernel, Dave Hansen
The generic linux/numa.h file defines NODES_SHIFT to 0 in case
the architecture did not.
Every architecture which has a NUMA config option defines
NODES_SHIFT in its asm-$ARCH headers, but only if NUMA is
enabled, except for x86_64.
This should make it like all the rest.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
---
work2-dave/include/asm-x86_64/numnodes.h | 2 --
1 files changed, 2 deletions(-)
diff -puN include/asm-x86_64/numnodes.h~x86_64-extra-NODES_SHIFT include/asm-x86_64/numnodes.h
--- work2/include/asm-x86_64/numnodes.h~x86_64-extra-NODES_SHIFT 2006-03-23 09:00:31.000000000 -0800
+++ work2-dave/include/asm-x86_64/numnodes.h 2006-03-23 09:00:31.000000000 -0800
@@ -5,8 +5,6 @@
#ifdef CONFIG_NUMA
#define NODES_SHIFT 6
-#else
-#define NODES_SHIFT 0
#endif
#endif
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86_64: extra NODES_SHIFT definition
2006-03-27 17:12 [PATCH] x86_64: extra NODES_SHIFT definition Dave Hansen
@ 2006-03-27 17:14 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-03-27 17:14 UTC (permalink / raw)
To: Dave Hansen; +Cc: linux-kernel
On Monday 27 March 2006 19:12, Dave Hansen wrote:
>
> The generic linux/numa.h file defines NODES_SHIFT to 0 in case
> the architecture did not.
>
> Every architecture which has a NUMA config option defines
> NODES_SHIFT in its asm-$ARCH headers, but only if NUMA is
> enabled, except for x86_64.
>
> This should make it like all the rest.
Applied thanks.
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-27 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-27 17:12 [PATCH] x86_64: extra NODES_SHIFT definition Dave Hansen
2006-03-27 17:14 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox