public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Frank Gevaerts <frank@gevaerts.be>
Cc: Robert Love <rlove@rlove.org>, linux-kernel@vger.kernel.org
Subject: Re: patch : hdaps on Thinkpad R52
Date: Tue, 28 Mar 2006 18:29:33 +0200	[thread overview]
Message-ID: <20060328182933.4184db3f.khali@linux-fr.org> (raw)
In-Reply-To: <20060314205758.GA9229@gevaerts.be>

Hi Frank,

> I had to add a new entry to the hdaps_whitelist table in hdaps.c to get
> my Thinkpad R52 recognized. Patch is attached
> (...)
>  	/* Note that DMI_MATCH(...,"ThinkPad T42") will match "ThinkPad T42p" */
>  	struct dmi_system_id hdaps_whitelist[] = {
> +		HDAPS_DMI_MATCH_NORMAL("ThinkPad H"),
>  		HDAPS_DMI_MATCH_INVERT("ThinkPad R50p"),
>  		HDAPS_DMI_MATCH_NORMAL("ThinkPad R50"),
>  		HDAPS_DMI_MATCH_NORMAL("ThinkPad R51"),

I have some doubt about this. The Thinkpad R52 is already supported
(with identifier string "ThinkPad R52", unsuprisingly) and "ThinkPad H"
doesn't exactly sound sane. Looks like your DMI data is corrupted or
something. Could you please provide the output of dmidecode and
vpddecode on your laptop?

Anyone else with a Thinkpad R52 can provide the same information for
comparison?

Feel free to send the outputs to me privately if you don't want to make
them public.

Thanks,
-- 
Jean Delvare

  parent reply	other threads:[~2006-03-28 16:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14 20:57 patch : hdaps on Thinkpad R52 Frank Gevaerts
2006-03-25 21:09 ` Adrian Bunk
2006-03-25 23:35   ` Arkadiusz Miskiewicz
2006-03-28 16:56     ` Jean Delvare
2006-03-29 16:44   ` [PATCH 2.6.16-rc4] hdaps: add support for " Frank Gevaerts
2006-03-28 16:29 ` Jean Delvare [this message]
2006-03-28 17:00   ` patch : hdaps on " Frank Gevaerts
2006-04-01 15:04     ` Jean Delvare
2006-04-01 21:32       ` Frank Gevaerts
2006-04-03 16:35       ` Frank Gevaerts
2006-04-08 15:02         ` Jean Delvare
2006-04-08 16:53           ` Frank Gevaerts
2006-10-11 14:07           ` Jean Delvare
2006-10-11 14:38             ` Frank Gevaerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060328182933.4184db3f.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=frank@gevaerts.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rlove@rlove.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox