Re: [PATCH] rtc: Added support for ds1672 control

[Alessandro Zummo <alessandro.zummo@towertech.it>]

On Tue, 28 Mar 2006 15:07:33 -0600 (CST)
Kumar Gala <galak@kernel.crashing.org> wrote:

 is almost ok, please check my comments below:

>  
>  	buf[0] = DS1672_REG_CNT_BASE;
>  	buf[1] = secs & 0x000000FF;
>  	buf[2] = (secs & 0x0000FF00) >> 8;
>  	buf[3] = (secs & 0x00FF0000) >> 16;
>  	buf[4] = (secs & 0xFF000000) >> 24;
> +	buf[5] = 0;

 I'd add a comment to say that 0 enables the osc.

> +static int ds1672_get_control(struct i2c_client *client)
> +{

[..]

> +	} else
> +		return val;
> +}

 I think it would be cleaner to define the routine as follow:
.. ds1672_get_control(...., unsigned char *status)

 and to usa the space provided by the caller to store the result.

> +	if (ds1672_get_control(client))
> +		state = "disabled";
> +	return sprintf(buf, "%s\n", state);
> +}

please #define DS1672_REG_CONTROL_EOSC 0x80
and check the single bit.


> +	err = ds1672_get_control(client);

 ditto.


 thanks for your work!

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it