Re: [PATCH] splice support #3

Jens Axboe
2006-03-30T14:37:17Z

On Thu, Mar 30 2006, Christoph Hellwig wrote:
> On Thu, Mar 30, 2006 at 03:15:30PM +0200, Jens Axboe wrote:
> > Hi,
> >
> > Ok, this should be it, I hope. Fixed the remaining issues spotted by
> > akpm, and also thanks to KAMEZAWA Hiroyuki for pointing out that the
> > page moving logic could get confused.
>
> Haven't looked at this in details, but two small comments already:
>
> - generic_file_splice_read/write should probably go to filemap.c
> where all the other generic pagecache file operations are

Perhaps, I kind of like it local to the splice stuff.

> - could we try to replace ->sendfile and ->sendfile with the splice
> operations completely? Having two different sets of zero-copy
> file to file transfer mechanisms will make the code pretty messy.

I've thought of that myself, and yes I hope we can implement
->sendfile() on top of splice if not now then in the immediate future.

--
Jens Axboe