public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: erich <erich@areca.com.tw>
Cc: "(?s?w????)?w?iO" <billion.wu@areca.com.tw>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, dax@gurulabs.com, ccaputo@alt.net,
	Matti Aarnio <matti.aarnio@zmailer.org>
Subject: Re: about ll_rw_blk.c of void generic_make_request(struct bio *bio)
Date: Thu, 30 Mar 2006 17:58:04 +0200	[thread overview]
Message-ID: <20060330155804.GP13476@suse.de> (raw)
In-Reply-To: <001d01c65302$0fee8e10$b100a8c0@erich2003>

On Wed, Mar 29 2006, erich wrote:
> Dear Jens Axboe,
> 
> I am an engineer of Areca (SATA RAID controller producer).
> I have coding linux driver for kernel.org "arcmsr".
> I have got dump message %s: rw=%ld, want=%Lu, limit=%Lu message from ext2 
> file system.
> But I am do well at Ext3 and all linux files system.
> This issue only occur at read command.
> Could you give me some info how to fix this bug in my linux scsi raid 
> driver?
> 
> About the code ll_rw_blk.c mention that "it may well happen - the kernel 
> calls bread() without checking the size of the device, e.g., when mounting 
> a device."
> 
> I hope that you have more experience with it and knew what's wrong I am 
> doing in my driver.
> 
> 
> generic_make_request(struct bio *bio)
> 
> if (maxsector)
> {
>  sector_t sector = bio->bi_sector;
> 
>  if (maxsector < nr_sectors || maxsector - nr_sectors < sector)
>  {
>   /*
>    * This may well happen - the kernel calls bread()
>    * without checking the size of the device, e.g., when
>    * mounting a device.
>    */
>   handle_bad_sector(bio);
>   goto end_io;
>  }
> }

I can't really say, from my recollection of leafing over lkml emails, I
seem to recall someone saying he hit this with a newer kernel where as
the older one did not?

What are the sectors exactly it complains about, eg the full line you
see?

-- 
Jens Axboe


  reply	other threads:[~2006-03-30 15:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-29  7:26 about ll_rw_blk.c of void generic_make_request(struct bio *bio) erich
2006-03-30 15:58 ` Jens Axboe [this message]
2006-03-31 17:32   ` Chris Caputo
2006-03-31 18:09     ` Chris Caputo
2006-03-31 20:22       ` Jens Axboe
2006-03-31 20:37         ` Chris Caputo
2006-04-06  9:32           ` erich
2006-04-06 11:44             ` Chris Caputo
2006-04-06 12:27               ` erich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060330155804.GP13476@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=billion.wu@areca.com.tw \
    --cc=ccaputo@alt.net \
    --cc=dax@gurulabs.com \
    --cc=erich@areca.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matti.aarnio@zmailer.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox