public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bridgett <adrian@smop.co.uk>
To: Andi Kleen <ak@muc.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.16-mm1 leaks in dvb playback (found)
Date: Fri, 31 Mar 2006 08:28:59 +0100	[thread overview]
Message-ID: <20060331072859.GA5389@smop.co.uk> (raw)
In-Reply-To: <20060331012235.GB45568@muc.de>

On Fri, Mar 31, 2006 at 03:22:35 +0200 (+0200), Andi Kleen wrote:
> On Thu, Mar 30, 2006 at 03:28:21PM -0800, David S. Miller wrote:
> > From: Adrian Bridgett <adrian@smop.co.uk>
> > Date: Fri, 31 Mar 2006 00:11:31 +0100
> > 
> > > Hmm - it looks like it was meant to be reverted in 2.6.16-rc1-mm4,5 FWIW.
> > 
> > So is the current version in Linus's tree causing this problem?

I'm taking 2.6.16(.0) adding -mm1.  When running dvbstream I get
dentry_cache and sock_inode_cache leaking about 4MB/s.

I then revert this ENFILE/EMFILE patch and both leaks stop.

I've just compiled up 2.6.16-git18 and that leaks in an identical
manner.   I'm suprised no-one else has seen it, so I've been putting
it down to the specific hardware (dvb-usb-vp7045), but then I saw that
it was a bad memory leak and then that 2.6.16 was fine and finally
started trying to isolate the patch that broke it for me (tm).

Maybe it's just exposed a bug in dvb-usb-vp7045, but given that it
appears to add a sock_alloc_fd without any matching deallocate code
AFAICT...

Adrian

  reply	other threads:[~2006-03-31  7:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-26 21:15 2.6.16-mm1 leaks in dvb playback Adrian Bridgett
2006-03-28  1:23 ` Andrew Morton
2006-03-28  7:02   ` adrian
2006-03-28  7:16     ` Andrew Morton
2006-03-29 23:37       ` adrian
2006-03-30  0:06         ` Andrew Morton
2006-03-30  0:45           ` Adrian Bridgett
2006-03-30 22:58             ` 2.6.16-mm1 leaks in dvb playback (found) Adrian Bridgett
2006-03-30 23:11               ` Adrian Bridgett
2006-03-30 23:28                 ` David S. Miller
2006-03-31  1:22                   ` Andi Kleen
2006-03-31  7:28                     ` Adrian Bridgett [this message]
2006-03-31  7:48                       ` David S. Miller
2006-03-31  9:54                         ` Adrian Bridgett
2006-03-31 10:07                           ` David S. Miller
2006-03-31 18:47                             ` Adrian Bridgett
2006-03-28  7:23     ` 2.6.16-mm1 leaks in dvb playback adrian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060331072859.GA5389@smop.co.uk \
    --to=adrian@smop.co.uk \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox