From: Matthew Wilcox <matthew@wil.cx>
To: Adrian Bunk <bunk@stusta.de>
Cc: Darren Jenkins <darrenrjenkins@gmail.com>,
kernel Janitors <kernel-janitors@lists.osdl.org>,
thomas@winischhofer.net, linux-kernel@vger.kernel.org
Subject: Re: [KJ][Patch] fix kbuild warning in sisfb.o
Date: Fri, 31 Mar 2006 06:55:57 -0700 [thread overview]
Message-ID: <20060331135557.GO13590@parisc-linux.org> (raw)
In-Reply-To: <20060331132929.GE3893@stusta.de>
On Fri, Mar 31, 2006 at 03:29:29PM +0200, Adrian Bunk wrote:
> > This is caused by the 'pci_driver struct' in sis_main.c having a pointer
> > to a 'pci_device_id struct' in 'sis_main.h' that is marked as
> > __devinitdata.
> >
> > The patch below just removes the __devinitdata annotation from the
> > 'pci_device_id struct', which seems like the best solution here.
>
> ACK, this is a bug that should be fixed.
If it is, then Documentation/pci.txt needs to be updated:
The struct pci_driver shouldn't be marked with any of these tags.
The ID table array should be marked __devinitdata.
parent reply other threads:[~2006-03-31 13:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20060331132929.GE3893@stusta.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060331135557.GO13590@parisc-linux.org \
--to=matthew@wil.cx \
--cc=bunk@stusta.de \
--cc=darrenrjenkins@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox