* Re: [KJ][Patch] fix kbuild warning in sisfb.o
[not found] ` <20060331132929.GE3893@stusta.de>
@ 2006-03-31 13:55 ` Matthew Wilcox
0 siblings, 0 replies; only message in thread
From: Matthew Wilcox @ 2006-03-31 13:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Darren Jenkins, kernel Janitors, thomas, linux-kernel
On Fri, Mar 31, 2006 at 03:29:29PM +0200, Adrian Bunk wrote:
> > This is caused by the 'pci_driver struct' in sis_main.c having a pointer
> > to a 'pci_device_id struct' in 'sis_main.h' that is marked as
> > __devinitdata.
> >
> > The patch below just removes the __devinitdata annotation from the
> > 'pci_device_id struct', which seems like the best solution here.
>
> ACK, this is a bug that should be fixed.
If it is, then Documentation/pci.txt needs to be updated:
The struct pci_driver shouldn't be marked with any of these tags.
The ID table array should be marked __devinitdata.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-31 13:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1143810678.7834.13.camel@localhost.localdomain>
[not found] ` <20060331132929.GE3893@stusta.de>
2006-03-31 13:55 ` [KJ][Patch] fix kbuild warning in sisfb.o Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox