From: Adrian Bunk <bunk@stusta.de>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [-mm patch] arch/i386/kernel/apic.c: make modern_apic() static
Date: Fri, 31 Mar 2006 17:16:10 +0200 [thread overview]
Message-ID: <20060331151610.GH3893@stusta.de> (raw)
In-Reply-To: <200603311702.19669.ak@suse.de>
On Fri, Mar 31, 2006 at 05:02:19PM +0200, Andi Kleen wrote:
> On Friday 31 March 2006 16:56, Adrian Bunk wrote:
> > This patch makes a nnedlessly global function static.
>
> Disagree. It will be likely used in more code in the future.
If this "likely" case becomes reality at any time in the future,
reverting my patch will be trivial.
OTOH, I have seen too many cases where people have said "I will need
this soon", and one year later it was still unused.
> -Andi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2006-03-31 15:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-28 8:35 2.6.16-mm2 Andrew Morton
2006-03-28 13:46 ` [PATCH 2.6.16-mm2] Kconfig SND_SEQUENCER_OSS help text fix Frederik Deweerdt
2006-03-28 22:23 ` Lee Revell
2006-03-29 7:36 ` Clemens Ladisch
2006-03-29 9:44 ` Frederik Deweerdt
2006-03-29 18:20 ` Takashi Iwai
2006-03-30 7:36 ` Frederik Deweerdt
2006-03-30 9:21 ` Rene Herman
2006-03-30 11:51 ` Frederik Deweerdt
2006-03-28 15:15 ` 2.6.16-mm2 bert hubert
2006-03-28 15:42 ` 2.6.16-mm2 Christoph Hellwig
2006-03-28 20:53 ` 2.6.16-mm2 Alan Cox
2006-03-28 18:16 ` 2.6.16-mm2 Badari Pulavarty
2006-03-28 19:11 ` 2.6.16-mm2 Andrew Morton
2006-03-28 19:38 ` 2.6.16-mm2 Andi Kleen
2006-03-28 19:59 ` 2.6.16-mm2 Badari Pulavarty
2006-03-28 21:52 ` 2.6.16-mm2 Kumar Gala
2006-03-28 22:05 ` 2.6.16-mm2 Russell King
2006-03-28 22:21 ` 2.6.16-mm2 Kumar Gala
2006-03-30 9:27 ` 2.6.16-mm2 Reuben Farrelly
2006-03-30 9:43 ` 2.6.16-mm2 Andrew Morton
2006-03-31 14:56 ` [-mm patch] arch/i386/kernel/apic.c: make modern_apic() static Adrian Bunk
2006-03-31 15:02 ` Andi Kleen
2006-03-31 15:16 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060331151610.GH3893@stusta.de \
--to=bunk@stusta.de \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox