From: Greg KH <greg@kroah.com>
To: Folkert van Heusden <folkert@vanheusden.com>
Cc: info@papouch.com, linux-kernel@vger.kernel.org, bryder@sgi.com
Subject: Re: Papouch USB thermometer support
Date: Fri, 31 Mar 2006 11:59:35 -0800 [thread overview]
Message-ID: <20060331195935.GA15859@kroah.com> (raw)
In-Reply-To: <20060324194655.GY4124@vanheusden.com>
On Fri, Mar 24, 2006 at 08:46:55PM +0100, Folkert van Heusden wrote:
> Hi,
>
> The following patch against 2.6.15 adds support for the www.Papouch.com
> USB thermometer by adding the appropriate vendor and product id.
>
>
> Signed off: Folkert van Heusden <folkert@vanheusden.com
It should be "Signed-off-by:".
> diff -uNrbBd old/ftdi_sio.c new/ftdi_sio.c
> --- old/ftdi_sio.c 2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.c 2006-03-24 20:33:20.000000000 +0100
Can you make it so I can apply the patch from the root of the kernel
tree? Documentation/SubmittingPatches describes how to create a patch
in this way.
> @@ -307,6 +307,7 @@
>
>
> static struct usb_device_id id_table_combined [] = {
> + { USB_DEVICE(PAPOUCHE_VENDOR, PAPOUCHE_THEM_PROD) },
> { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
Your email client ate the tabs :(
> { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
> diff -uNrbBd old/ftdi_sio.h new/ftdi_sio.h
> --- old/ftdi_sio.h 2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.h 2006-03-24 20:37:35.000000000 +0100
> @@ -20,8 +20,13 @@
> * Philipp G?hring - pg@futureware.at - added the Device ID of the USB relais
> * from Rudolf Gugler
> *
> + * Folkert van Heusden - folkert@vanheusden.com - added the device id of the
> + * temperature sensor from www.papouch.com
This information doesn't belong in the file, only in the changelog.
It's not needed.
Care to redo this?
thanks,
greg k-h
prev parent reply other threads:[~2006-03-31 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 19:46 Papouch USB thermometer support Folkert van Heusden
2006-03-26 15:35 ` Kalin KOZHUHAROV
2006-03-31 19:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060331195935.GA15859@kroah.com \
--to=greg@kroah.com \
--cc=bryder@sgi.com \
--cc=folkert@vanheusden.com \
--cc=info@papouch.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox