From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751269AbWDAKqv (ORCPT ); Sat, 1 Apr 2006 05:46:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751282AbWDAKqv (ORCPT ); Sat, 1 Apr 2006 05:46:51 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:21266 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1751269AbWDAKqu (ORCPT ); Sat, 1 Apr 2006 05:46:50 -0500 Date: Sat, 1 Apr 2006 12:46:49 +0200 From: Adrian Bunk To: Greg KH , Kumar Gala , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: removal of EXPORT_SYMBOL(insert_resource)? Message-ID: <20060401104649.GG28310@stusta.de> References: <20060304005935.GA27548@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060304005935.GA27548@kroah.com> User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Kumar, any news regarding a submission of your code? cu Adrian On Fri, Mar 03, 2006 at 04:59:35PM -0800, Greg KH wrote: > On Thu, Mar 02, 2006 at 01:31:08PM -0600, Kumar Gala wrote: > > I have a situation that I believe warrants leaving insert_resource as an > > exported API. > > > > I've got a bus implementation that it done as a module. While I'm more > > than happy to provide this bus implementation to be included in the > > mainline, I dont think it makes much sense to do so. The code is only > > useful to an extremely small handful of people. If we want to clutter the > > kernel with it I'm happy to provide a patch for it. > > Please do, keeping code outside the kernel makes it _very_ hard on you. > It makes it easier if everything is in-the-tree, as you know. > > Hell, we have two whole x86 subarchs with only 4 machines each in > existance, a simple bus is nothing :) > > > The situation I have is a FPGA connect over PCI. The FPGA implements a > > number of different "functions" but uses PCI more like an SoC bus than a > > true PCI device. Anyways, in some discussions with gregkh, it was > > suggested the best thing was to create a new bus type that the "fpga" > > drivers would bind to. > > > > I use insert_resource to handle registering the MMIO regions for each > > device (similar to how platform devices are registered). > > All the better reason to get it into the tree... > > thanks, > > greg k-h