public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Horms <horms@verge.net.au>
To: "Randy.Dunlap" <rdunlap@xenotime.net>, Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, fastboot@osdl.org, ebiederm@xmission.com
Subject: Re: [PATCH] kexec: typo in machine_kexec()
Date: Wed, 5 Apr 2006 14:57:54 +0900	[thread overview]
Message-ID: <20060405055754.GA3277@verge.net.au> (raw)
In-Reply-To: <200604051310.55956.kernel@kolivas.org> <20060404200557.1e95bdd8.rdunlap@xenotime.net>

On Tue, Apr 04, 2006 at 08:05:57PM -0700, Randy.Dunlap wrote:
> On Wed, 5 Apr 2006 08:48:08 +0900 Horms wrote:
> 
> > Signed-Off-By: Horms <horms@verge.net.au
> > 
> >  machine_kexec.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Can you use diffstat -p1 ?  does git allow/support that option, so that
> more complete filenames are visible?

Sure, I have done that. I actually use a script to grab
the changelog (of my local commit), do the diffstat, and get the 
patch, as I'm not sure how to get git to do that in one pass.

> > -	 * The more common model is are caches where the behide
> > +	 * The more common model is are caches where the behind
> 
> Also delete /are/, but that sentence and the previous one still need some
> work, so fixing "behide" isn't a big deal IMO.  However, Eric can decide
> about the patch; he is the kexec maintainer.

Yeah, I puzzled over it a bit which is why I send in my original (poor) fix.
Removing the are helps a lot. Here is an updated patch which is
marginally better than my first pass.

kexec: comment fixes in machine_kexec()

 arch/i386/kernel/machine_kexec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

720f4f4a47cf856a705b59875c099770d3b4bd5f
diff --git a/arch/i386/kernel/machine_kexec.c b/arch/i386/kernel/machine_kexec.c
index f73d737..d31d250 100644
--- a/arch/i386/kernel/machine_kexec.c
+++ b/arch/i386/kernel/machine_kexec.c
@@ -194,7 +194,7 @@ NORET_TYPE void machine_kexec(struct kim
 	 * set them to a specific selector, but this table is never
 	 * accessed again you set the segment to a different selector.
 	 *
-	 * The more common model is are caches where the behide
+	 * The more common model is caches where the behind
 	 * the scenes work is done, but is also dropped at arbitrary
 	 * times.
 	 *

  parent reply	other threads:[~2006-04-05  6:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-04 23:48 [PATCH] kexec: typo in machine_kexec() Horms
2006-04-05  3:05 ` Randy.Dunlap
2006-04-05  5:56   ` Eric W. Biederman
2006-04-05 15:19     ` [PATCH] kexec: update MAINTAINERS Randy.Dunlap
2006-04-05  5:57   ` Horms [this message]
2006-04-05  6:24     ` [PATCH] kexec: typo in machine_kexec() Con Kolivas
2006-04-05 15:49       ` Eric W. Biederman
2006-04-05 17:09         ` Randy.Dunlap
2006-05-20  2:09     ` Horms
2006-04-05  3:10 ` Con Kolivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060405055754.GA3277@verge.net.au \
    --to=horms@verge.net.au \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@osdl.org \
    --cc=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox