public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] ISDN_DRV_GIGASET should select, not depend on CRC_CCITT
@ 2006-04-05 16:32 Adrian Bunk
  2006-04-05 17:05 ` Tilman Schmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-04-05 16:32 UTC (permalink / raw)
  To: hjlipp, tilman; +Cc: gigaset307x-common, kkeil, isdn4linux, linux-kernel

CRC_CCITT is an internal helper function that should be select'ed.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.17-rc1-mm1-full/drivers/isdn/gigaset/Kconfig.old	2006-04-05 17:42:54.000000000 +0200
+++ linux-2.6.17-rc1-mm1-full/drivers/isdn/gigaset/Kconfig	2006-04-05 17:43:07.000000000 +0200
@@ -3,7 +3,8 @@
 
 config ISDN_DRV_GIGASET
 	tristate "Siemens Gigaset support (isdn)"
-	depends on ISDN_I4L && CRC_CCITT
+	depends on ISDN_I4L
+	select CRC_CCITT
 	help
 	  Say m here if you have a Gigaset or Sinus isdn device.
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] ISDN_DRV_GIGASET should select, not depend on CRC_CCITT
  2006-04-05 16:32 [2.6 patch] ISDN_DRV_GIGASET should select, not depend on CRC_CCITT Adrian Bunk
@ 2006-04-05 17:05 ` Tilman Schmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Tilman Schmidt @ 2006-04-05 17:05 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: hjlipp, gigaset307x-common, kkeil, isdn4linux, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On 05.04.2006 18:32, Adrian Bunk wrote:
> CRC_CCITT is an internal helper function that should be select'ed.

Good point. Thanks.

> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Tilman Schmidt <tilman@imap.cc>

> 
> --- linux-2.6.17-rc1-mm1-full/drivers/isdn/gigaset/Kconfig.old	2006-04-05 17:42:54.000000000 +0200
> +++ linux-2.6.17-rc1-mm1-full/drivers/isdn/gigaset/Kconfig	2006-04-05 17:43:07.000000000 +0200
> @@ -3,7 +3,8 @@
>  
>  config ISDN_DRV_GIGASET
>  	tristate "Siemens Gigaset support (isdn)"
> -	depends on ISDN_I4L && CRC_CCITT
> +	depends on ISDN_I4L
> +	select CRC_CCITT
>  	help
>  	  Say m here if you have a Gigaset or Sinus isdn device.
>  
> 


-- 
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-05 17:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-05 16:32 [2.6 patch] ISDN_DRV_GIGASET should select, not depend on CRC_CCITT Adrian Bunk
2006-04-05 17:05 ` Tilman Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox