From: Greg KH <greg@kroah.com>
To: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
akpm@osdl.org,
TPM Device Driver List <tpmdd-devel@lists.sourceforge.net>,
Marcel Selhorst <selhorst@crypto.rub.de>
Subject: Re: PATCH 6/7] tpm: new 1.2 sysfs files - Updated patch
Date: Wed, 5 Apr 2006 13:08:31 -0700 [thread overview]
Message-ID: <20060405200831.GA3951@kroah.com> (raw)
In-Reply-To: <1144266504.5235.44.camel@localhost.localdomain>
On Wed, Apr 05, 2006 at 02:48:24PM -0500, Kylene Jo Hall wrote:
> On Mon Apr 03, 2006 at 21:47:25 Greg KH wrote:
> <snip>
> > > +EXPORT_SYMBOL_GPL(tpm_show_state);
> >
> > That is more than one value per file. Please make unique files for the
> > different capabilities. As it stands the file doesn't make too much
> > sense for someone reading it and not understanding that each line is a
> > different portion of the state.
> >
> > thanks,
> >
> > greg k-h
> tpm_show_state removed in this patch in favor of separate files.
Thanks for changing this, looks much better now.
greg k-h
prev parent reply other threads:[~2006-04-05 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 19:48 PATCH 6/7] tpm: new 1.2 sysfs files - Updated patch Kylene Jo Hall
2006-04-05 20:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060405200831.GA3951@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=selhorst@crypto.rub.de \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox