From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932099AbWDFGnP (ORCPT ); Thu, 6 Apr 2006 02:43:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751135AbWDFGnP (ORCPT ); Thu, 6 Apr 2006 02:43:15 -0400 Received: from pasmtp.tele.dk ([193.162.159.95]:27661 "EHLO pasmtp.tele.dk") by vger.kernel.org with ESMTP id S1751130AbWDFGnP (ORCPT ); Thu, 6 Apr 2006 02:43:15 -0400 Date: Thu, 6 Apr 2006 08:43:10 +0200 From: Sam Ravnborg To: Andreas Gruenbacher Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] modules_install must not remove existing modules Message-ID: <20060406064310.GA24785@mars.ravnborg.org> References: <200604052333.51085.agruen@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200604052333.51085.agruen@suse.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 05, 2006 at 11:33:50PM +0200, Andreas Gruenbacher wrote: > When installing external modules with `make modules_install', the > first thing that happens is a rm -rf of the target directory. This > works only once, and breaks when installing more than one (set of) > external module(s). Bug introduced in: > http://www.kernel.org/hg/linux-2.6/?cs=bbb3915836f5 > > Sam, is this fix okay with you? Applied. We should document this somewhere... Sam