Re: [PATCH] Fix pciehp driver on non ACPI systems

Greg KH
2006-04-06T18:00:21Z

On Thu, Apr 06, 2006 at 07:46:44PM +0200, Sam Ravnborg wrote:
> On Thu, Apr 06, 2006 at 10:41:13AM -0700, Randy.Dunlap wrote:
> > On Thu, 6 Apr 2006 09:05:27 -0700 Greg KH wrote:
> >
> > > On Thu, Apr 06, 2006 at 08:17:31PM +1000, Anton Blanchard wrote:
> > > >
> > > > Wrap some ACPI specific headers. ACPI hasnt taken over the whole world yet.
> > > >
> > > > Signed-off-by: Anton Blanchard <anton@samba.org>
> > > > ---
> > > >
> > > > Index: kernel/drivers/pci/hotplug/pciehp_hpc.c
> > > > ===================================================================
> > > > --- kernel.orig/drivers/pci/hotplug/pciehp_hpc.c 2006-04-06 05:01:32.000000000 -0500
> > > > +++ kernel/drivers/pci/hotplug/pciehp_hpc.c 2006-04-06 05:09:48.501122395 -0500
> > > > @@ -38,10 +38,14 @@
> > > >
> > > > #include "../pci.h"
>
> When one introdues relative apths like the above this is a good sign
> that the header file ought to move to a common place somewhere in
> include/.

No, this is a pci-core only header file. I really don't want to have
these in include/linux/pci.h as no one other than the pci core, or pci
hotplug drivers need to use it.

I guess I could create,
include/linux/pci-core-only-dont-use-unless-you-really-know-what-you-are-doing.h
but that might be a bit rude :)

thanks,

greg k-h