From: Greg KH <greg@kroah.com>
To: Anton Blanchard <anton@samba.org>
Cc: akpm@osdl.org, gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix pciehp driver on non ACPI systems
Date: Thu, 6 Apr 2006 09:05:27 -0700 [thread overview]
Message-ID: <20060406160527.GA2965@kroah.com> (raw)
In-Reply-To: <20060406101731.GA9989@krispykreme>
On Thu, Apr 06, 2006 at 08:17:31PM +1000, Anton Blanchard wrote:
>
> Wrap some ACPI specific headers. ACPI hasnt taken over the whole world yet.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> Index: kernel/drivers/pci/hotplug/pciehp_hpc.c
> ===================================================================
> --- kernel.orig/drivers/pci/hotplug/pciehp_hpc.c 2006-04-06 05:01:32.000000000 -0500
> +++ kernel/drivers/pci/hotplug/pciehp_hpc.c 2006-04-06 05:09:48.501122395 -0500
> @@ -38,10 +38,14 @@
>
> #include "../pci.h"
> #include "pciehp.h"
> +
> +#ifdef CONFIG_ACPI
> #include <acpi/acpi.h>
> #include <acpi/acpi_bus.h>
> #include <acpi/actypes.h>
> #include <linux/pci-acpi.h>
> +#endif
Shouldn't the ACPI headers handle it if CONFIG_ACPI is not enabled? All
other header files work that way, and we shouldn't have to add this to
the .c files.
thanks,
greg k-h
next prev parent reply other threads:[~2006-04-06 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 10:17 [PATCH] Fix pciehp driver on non ACPI systems Anton Blanchard
2006-04-06 16:05 ` Greg KH [this message]
2006-04-06 17:41 ` Randy.Dunlap
2006-04-06 17:46 ` Sam Ravnborg
2006-04-06 17:57 ` Greg KH
2006-04-06 18:14 ` Sam Ravnborg
2006-04-12 22:28 ` Greg KH
2006-04-06 18:27 ` Greg KH
2006-04-06 18:58 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060406160527.GA2965@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox