From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@osdl.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@elte.hu>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] coredump: speedup SIGKILL sending
Date: Fri, 7 Apr 2006 02:06:28 +0400 [thread overview]
Message-ID: <20060406220628.GA237@oleg> (raw)
With this patch a thread group is killed atomically under ->siglock.
This is faster because we can use sigaddset() instead of force_sig_info()
and this is used in further patches.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- rc1/fs/exec.c~2_KILL 2006-04-06 15:10:28.000000000 +0400
+++ rc1/fs/exec.c 2006-04-06 15:19:33.000000000 +0400
@@ -1387,17 +1387,24 @@ static void format_corename(char *corena
static void zap_process(struct task_struct *start, int *ptraced)
{
struct task_struct *t;
+ unsigned long flags;
+
+ spin_lock_irqsave(&start->sighand->siglock, flags);
t = start;
do {
if (t != current && t->mm) {
t->mm->core_waiters++;
- force_sig_specific(SIGKILL, t);
+ sigaddset(&t->pending.signal, SIGKILL);
+ signal_wake_up(t, 1);
+
if (unlikely(t->ptrace) &&
unlikely(t->parent->mm == t->mm))
*ptraced = 1;
}
} while ((t = next_thread(t)) != start);
+
+ spin_unlock_irqrestore(&start->sighand->siglock, flags);
}
static void zap_threads (struct mm_struct *mm)
next reply other threads:[~2006-04-06 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 22:06 Oleg Nesterov [this message]
2006-04-06 19:45 ` [PATCH 2/4] coredump: speedup SIGKILL sending Lee Revell
2006-04-06 23:55 ` Oleg Nesterov
2006-04-06 20:07 ` Lee Revell
2006-04-07 23:28 ` Oleg Nesterov
2006-04-07 19:42 ` Lee Revell
2006-04-10 4:11 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060406220628.GA237@oleg \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox