Re: [PATCH 4/4] MultiAdmin module

Greg KH
2006-05-01T15:07:45Z

On Mon, May 01, 2006 at 03:50:21PM +0200, Jan Engelhardt wrote:
>
> [PATCH 4/4] MultiAdmin module
>
> - Add the MultiAdmin to the mainline tree.
> I hope the rest is self-explanatory.
>
> Please do not mention CodingStyle for multiadm.c. I already know it. :)
> And I will get to it should it really be merged.

No one will review it if it isn't in the proper CodingStyle.

We have a coding style for a reason, it makes it a very simple thing for
anyone to review the code as the patterns are all the same. It turns
out that people's brains get trained to ignore the patterns and see the
details instead. Lots of research backs this up.

So switch to the common coding style, otherwise no one will look at your
code (or if they do, odds are they will miss a lot...)

thanks,

greg k-h