Re: [PATCH 4/4] MultiAdmin module

James Morris
2006-05-01T14:56:36Z

On Mon, 1 May 2006, Jan Engelhardt wrote:

> +#if !defined(CONFIG_SECURITY_CAPABILITIES) && \
> + !defined(CONFIG_SECURITY_CAPABILITIES_MODULE)
> +# error You need to have CONFIG_SECURITY_CAPABILITIES=y or =m \
> + for MultiAdmin to compile successfully.
> +#endif

This is what Kconfig language is for.

> +typedef int bool;

You won't get much worthwile review of this code until you clean it up and
make it conform to kernel coding style.

- James
--
James Morris
<jmorris@namei.org>