[PATCH] trivial fs/select.c compiler warning fix

[PATCH] trivial fs/select.c compiler warning fix

[Horst Schirmeier]

This trivial patch fixes
fs/select.c: In function `core_sys_select':
fs/select.c:339: warning: assignment from incompatible pointer type
fs/select.c:376: warning: comparison of distinct pointer types lacks a cast
by casting to (char *) when accessing stack_fds.

Signed-off-by: Horst Schirmeier <horst@schirmeier.com>

---

diff --git a/fs/select.c b/fs/select.c
index 071660f..3025cec 100644
--- a/fs/select.c
+++ b/fs/select.c
@@ -336,7 +336,7 @@ static int core_sys_select(int n, fd_set
 	ret = -ENOMEM;
 	size = FDS_BYTES(n);
 	if (6*size < SELECT_STACK_ALLOC)
-		bits = stack_fds;
+		bits = (char *) stack_fds;
 	else
 		bits = kmalloc(6 * size, GFP_KERNEL);
 	if (!bits)
@@ -373,7 +373,7 @@ static int core_sys_select(int n, fd_set
 		ret = -EFAULT;
 
 out:
-	if (bits != stack_fds)
+	if (bits != (char *) stack_fds)
 		kfree(bits);
 out_nofds:
 	return ret;

-- 
PGP-Key 0xD40E0E7A

Re: [PATCH] trivial fs/select.c compiler warning fix

[Horst Schirmeier]

Whoops. Looks like Russell King already created a more elaborate patch
for this problem yesterday (20060407153715.GA31458@flint.arm.linux.org.uk).

On Sat, 08 Apr 2006, Horst Schirmeier wrote:
> This trivial patch fixes
> fs/select.c: In function `core_sys_select':
> fs/select.c:339: warning: assignment from incompatible pointer type
> fs/select.c:376: warning: comparison of distinct pointer types lacks a cast
> by casting to (char *) when accessing stack_fds.
> 
> Signed-off-by: Horst Schirmeier <horst@schirmeier.com>
> 
> ---
> 
> diff --git a/fs/select.c b/fs/select.c
> index 071660f..3025cec 100644
> --- a/fs/select.c
> +++ b/fs/select.c
> @@ -336,7 +336,7 @@ static int core_sys_select(int n, fd_set
>  	ret = -ENOMEM;
>  	size = FDS_BYTES(n);
>  	if (6*size < SELECT_STACK_ALLOC)
> -		bits = stack_fds;
> +		bits = (char *) stack_fds;
>  	else
>  		bits = kmalloc(6 * size, GFP_KERNEL);
>  	if (!bits)
> @@ -373,7 +373,7 @@ static int core_sys_select(int n, fd_set
>  		ret = -EFAULT;
>  
>  out:
> -	if (bits != stack_fds)
> +	if (bits != (char *) stack_fds)
>  		kfree(bits);
>  out_nofds:
>  	return ret;
> 

-- 
PGP-Key 0xD40E0E7A