public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, hpa@zytor.com, mm-commits@vger.kernel.org
Subject: Re: + git-klibc-mktemp-fix.patch added to -mm tree
Date: Sat, 8 Apr 2006 22:14:12 +0200	[thread overview]
Message-ID: <20060408201412.GA26946@mars.ravnborg.org> (raw)
In-Reply-To: <200604080707.k38778VV023208@shell0.pdx.osdl.net>

On Sat, Apr 08, 2006 at 12:05:54AM -0700, akpm@osdl.org wrote:
> diff -puN usr/dash/mkbuiltins~git-klibc-mktemp-fix usr/dash/mkbuiltins
> --- 25/usr/dash/mkbuiltins~git-klibc-mktemp-fix	Sat Apr  8 14:51:11 2006
> +++ 25-akpm/usr/dash/mkbuiltins	Sat Apr  8 14:51:11 2006
> @@ -37,7 +37,7 @@
>  
>  tempfile=tempfile
>  if ! type tempfile > /dev/null 2>&1; then
> -	tempfile=mktemp
> +	tempfile="mktemp /tmp/tmp.XXXXXX"

Shouldn't that be:
> +	tempfile="$(mktemp /tmp/tmp.XXXXXX)"

	Sam

       reply	other threads:[~2006-04-08 20:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200604080707.k38778VV023208@shell0.pdx.osdl.net>
2006-04-08 20:14 ` Sam Ravnborg [this message]
2006-04-08 20:27   ` + git-klibc-mktemp-fix.patch added to -mm tree H. Peter Anvin
2006-04-09  5:33     ` Herbert Xu
2006-04-10  7:33     ` Keith Owens
2006-04-10 14:45       ` H. Peter Anvin
     [not found] <5Zs4F-ba-13@gated-at.bofh.it>
     [not found] ` <5Zs4F-ba-11@gated-at.bofh.it>
2006-04-08 23:34   ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060408201412.GA26946@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox