From: Oleg Nesterov <oleg@tv-sign.ru>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
Date: Sun, 9 Apr 2006 01:23:43 +0400 [thread overview]
Message-ID: <20060408212343.GB1845@oleg> (raw)
In-Reply-To: <20060408211308.GA1845@oleg>
On 04/09, Oleg Nesterov wrote:
>
> proc_task_readdir:
>
> first_tid() returns old_leader
>
> next_tid() returns new_leader
>
> de_thread:
> old_leader->group_leader = new_leader;
>
>
> next_rid() returns old_leader again,
> because it is not thread_group_leader()
> anymore
I think something like this for next_tid() is sufficient:
- if (thread_group_leader(pos))
+ if (pos->pid == pos->tgid)
We can also do the same change in first_tgid().
Oleg.
next prev parent reply other threads:[~2006-04-08 17:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 22:04 [PATCH rc1-mm] de_thread: fix deadlockable process addition Oleg Nesterov
2006-04-06 22:58 ` Eric W. Biederman
2006-04-07 23:46 ` Oleg Nesterov
2006-04-07 22:51 ` Andrew Morton
2006-04-07 22:56 ` Andrew Morton
2006-04-08 7:55 ` Eric W. Biederman
2006-04-08 17:27 ` Oleg Nesterov
2006-04-08 16:07 ` Eric W. Biederman
2006-04-08 21:13 ` Oleg Nesterov
2006-04-08 21:23 ` Oleg Nesterov [this message]
2006-04-10 22:11 ` Eric W. Biederman
2006-04-10 23:07 ` [PATCH] de_thread: Don't confuse users do_each_thread Eric W. Biederman
2006-04-10 23:16 ` Eric W. Biederman
2006-04-10 23:52 ` Ingo Oeser
2006-04-11 6:18 ` Eric W. Biederman
2006-04-11 10:19 ` Oleg Nesterov
2006-04-11 7:25 ` Ingo Oeser
2006-04-11 7:36 ` Eric W. Biederman
2006-04-11 19:50 ` Ingo Oeser
2006-04-11 10:05 ` Oleg Nesterov
2006-04-11 5:23 ` Andrew Morton
2006-04-11 10:47 ` Oleg Nesterov
2006-04-11 6:23 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060408212343.GB1845@oleg \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox