From: Darren Hart <dvhltc@us.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"Stultz, John" <johnstul@us.ibm.com>,
Peter Williams <pwil3058@bigpond.net.au>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: RT task scheduling
Date: Sun, 9 Apr 2006 10:25:16 -0700 [thread overview]
Message-ID: <200604091025.17518.dvhltc@us.ibm.com> (raw)
In-Reply-To: <20060409131649.GA19082@elte.hu>
On Sunday 09 April 2006 06:16, Ingo Molnar wrote:
> * Darren Hart <darren@dvhart.com> wrote:
> > My last mail specifically addresses preempt-rt, but I'd like to know
> > people's thoughts regarding this issue in the mainline kernel. Please
> > see my previous post "realtime-preempt scheduling - rt_overload
> > behavior" for a testcase that produces unpredictable scheduling
> > results.
>
> thanks for the testcase! It indeed triggered a bug in the -rt tree's
> "RT-overload" balancing feature. The nature of the bug made it trigger
> much less likely on 2-way boxes (where i do most of my -rt testing),
> probably that's why it didnt get discovered before. I've uploaded the
> -rt14 tree with this bug fixed - does it fix the failures for you?
I ran the test 100 times, no failures! Looks good to me.
# for ((i=0;i<100;i++)); do ./sched_football 4 10 | grep "Final ball position"
| tee sched_football_ball.log; sleep 1; done
Final ball position: 0
...
Final ball position: 0
Looking at the patch, it looks like the problem was a race on the runqueue
lock - when we called double_runqueue_lock(a,b) we risked dropping the lock
on b, giving another CPU opportunity to grab it and pull our next task. The
API change to double_runqueue_lock() and checking the new return code in
balance_rt_tasks() is what fixed the issue. Is that accurate?
I was doing some testing to see why the RT tasks don't appear to be evenly
distributed across the CPUs (in my earlier post using the output
of /proc/stat). I was wondering if the load_balancing code might be
interfering with the balance_rt_tasks() code. Should the normal
load_balancer even touch RT tasks in the presence of balance_rt_tasks() ?
I'm thinking not.
Thanks,
--
Darren Hart
IBM Linux Technology Center
Realtime Linux Team
Phone: 503 578 3185
T/L: 775 3185
next prev parent reply other threads:[~2006-04-09 17:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 3:25 RT task scheduling Darren Hart
2006-04-06 4:19 ` Peter Williams
2006-04-06 17:24 ` Darren Hart
2006-04-06 23:02 ` Peter Williams
2006-04-06 7:37 ` Ingo Molnar
2006-04-06 14:55 ` Darren Hart
2006-04-06 18:16 ` Darren Hart
2006-04-06 22:35 ` Darren Hart
2006-04-07 22:58 ` Vernon Mauery
2006-04-06 23:06 ` Peter Williams
2006-04-07 3:07 ` Bill Huey
2006-04-07 7:11 ` Ingo Molnar
2006-04-07 8:39 ` Bill Huey
2006-04-07 9:11 ` Bill Huey
2006-04-07 9:19 ` Ingo Molnar
2006-04-07 10:39 ` Bill Huey
2006-04-07 10:51 ` Ingo Molnar
2006-04-07 11:14 ` Bill Huey
2006-04-07 11:29 ` Ingo Molnar
2006-04-07 22:18 ` Bill Huey
2006-04-07 14:56 ` Darren Hart
2006-04-07 21:06 ` Bill Huey
2006-04-07 22:37 ` Darren Hart
2006-04-07 23:36 ` Bill Huey
2006-04-08 3:01 ` Steven Rostedt
2006-04-08 4:28 ` Vernon Mauery
2006-04-08 4:45 ` Steven Rostedt
2006-04-08 7:16 ` Ingo Molnar
2006-04-08 7:25 ` Ingo Molnar
2006-04-08 7:54 ` Bill Huey
2006-04-08 8:03 ` Ingo Molnar
2006-04-08 10:02 ` Bill Huey
2006-04-08 0:11 ` Peter Williams
2006-04-07 9:23 ` Bill Huey
2006-04-09 13:16 ` Ingo Molnar
2006-04-09 17:25 ` Darren Hart [this message]
2006-04-09 18:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604091025.17518.dvhltc@us.ibm.com \
--to=dvhltc@us.ibm.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pwil3058@bigpond.net.au \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox