* [2.6 patch] dvb/bt8xx/bt878.c: don't export static variables
@ 2006-04-09 17:48 Adrian Bunk
2006-04-09 18:41 ` Manu Abraham
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-04-09 17:48 UTC (permalink / raw)
To: v4l-dvb-maintainer; +Cc: linux-kernel
Static variables mustn't be EXPORT_SYMBOL'ed.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/dvb/bt8xx/bt878.c | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.17-rc1-mm2-full/drivers/media/dvb/bt8xx/bt878.c.old 2006-04-09 18:43:28.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/drivers/media/dvb/bt8xx/bt878.c 2006-04-09 18:44:26.000000000 +0200
@@ -54,26 +54,24 @@
static unsigned int bt878_verbose = 1;
static unsigned int bt878_debug;
module_param_named(verbose, bt878_verbose, int, 0444);
MODULE_PARM_DESC(verbose,
"verbose startup messages, default is 1 (yes)");
module_param_named(debug, bt878_debug, int, 0644);
MODULE_PARM_DESC(debug, "Turn on/off debugging, default is 0 (off).");
int bt878_num;
struct bt878 bt878[BT878_MAX];
-EXPORT_SYMBOL(bt878_debug);
-EXPORT_SYMBOL(bt878_verbose);
EXPORT_SYMBOL(bt878_num);
EXPORT_SYMBOL(bt878);
#define btwrite(dat,adr) bmtwrite((dat), (bt->bt878_mem+(adr)))
#define btread(adr) bmtread(bt->bt878_mem+(adr))
#define btand(dat,adr) btwrite((dat) & btread(adr), adr)
#define btor(dat,adr) btwrite((dat) | btread(adr), adr)
#define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr)
#if defined(dprintk)
#undef dprintk
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] dvb/bt8xx/bt878.c: don't export static variables
2006-04-09 17:48 [2.6 patch] dvb/bt8xx/bt878.c: don't export static variables Adrian Bunk
@ 2006-04-09 18:41 ` Manu Abraham
0 siblings, 0 replies; 2+ messages in thread
From: Manu Abraham @ 2006-04-09 18:41 UTC (permalink / raw)
To: Adrian Bunk; +Cc: v4l-dvb-maintainer, linux-kernel
Adrian Bunk wrote:
> Static variables mustn't be EXPORT_SYMBOL'ed.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> drivers/media/dvb/bt8xx/bt878.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.17-rc1-mm2-full/drivers/media/dvb/bt8xx/bt878.c.old 2006-04-09 18:43:28.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-full/drivers/media/dvb/bt8xx/bt878.c 2006-04-09 18:44:26.000000000 +0200
> @@ -54,26 +54,24 @@
> static unsigned int bt878_verbose = 1;
> static unsigned int bt878_debug;
>
> module_param_named(verbose, bt878_verbose, int, 0444);
> MODULE_PARM_DESC(verbose,
> "verbose startup messages, default is 1 (yes)");
> module_param_named(debug, bt878_debug, int, 0644);
> MODULE_PARM_DESC(debug, "Turn on/off debugging, default is 0 (off).");
>
> int bt878_num;
> struct bt878 bt878[BT878_MAX];
>
> -EXPORT_SYMBOL(bt878_debug);
> -EXPORT_SYMBOL(bt878_verbose);
> EXPORT_SYMBOL(bt878_num);
> EXPORT_SYMBOL(bt878);
>
> #define btwrite(dat,adr) bmtwrite((dat), (bt->bt878_mem+(adr)))
> #define btread(adr) bmtread(bt->bt878_mem+(adr))
>
> #define btand(dat,adr) btwrite((dat) & btread(adr), adr)
> #define btor(dat,adr) btwrite((dat) | btread(adr), adr)
> #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr)
>
> #if defined(dprintk)
> #undef dprintk
>
> -
>
Ack'd-by: Manu Abraham <manu@linuxtv.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-09 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-09 17:48 [2.6 patch] dvb/bt8xx/bt878.c: don't export static variables Adrian Bunk
2006-04-09 18:41 ` Manu Abraham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox