From: Andi Kleen <ak@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i386/x86-64: Return defined error value for bad PCI config space accesses
Date: Sun, 9 Apr 2006 21:55:34 +0200 [thread overview]
Message-ID: <200604092155.34488.ak@suse.de> (raw)
In-Reply-To: <44395DD2.8080700@garzik.org>
On Sunday 09 April 2006 21:17, Jeff Garzik wrote:
> As the code check indicates, value might be NULL.
>
> Please fix.
It should never be NULL. If anything that's a BUG_ON, but crashing on it is ok
too.
But I'll change it to a BUG_ON in the next patch thanks.
-Andi
prev parent reply other threads:[~2006-04-09 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200604091900.k39J0uVn013016@hera.kernel.org>
2006-04-09 19:17 ` [PATCH] i386/x86-64: Return defined error value for bad PCI config space accesses Jeff Garzik
2006-04-09 19:55 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604092155.34488.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox