From: David Brownell <david-b@pacbell.net>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linux-usb-devel@lists.sourceforge.net, Greg KH <gregkh@suse.de>,
LKML mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] compile error when building multiple EHCI host controllers as modules
Date: Mon, 10 Apr 2006 12:11:23 -0700 [thread overview]
Message-ID: <200604101211.23871.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0604051231030.17147-100000@gate.crashing.org>
> +
> +#ifdef CONFIG_PPC_83xx
> + retval = platform_driver_register(&ehci_fsl_dr_driver);
> + if (retval < 0)
> + return retval;
> +
> + retval = platform_driver_register(&ehci_fsl_dr_driver);
> + if (retval < 0)
> + return retval;
> +#endif
> +
> +#ifdef CONFIG_SOC_AU1X00
> + pr_debug(DRIVER_INFO " (Au1xxx)\n");
> +
> + retval = driver_register(&ehci_hcd_au1xxx_driver);
> + if (retval < 0)
> + return retval;
> +#endif
Can we just get away from all of that extra #ifdeffery?
This is essentially the same patch you sent the first time.
With the same bugs ... like, not cleaning up the first driver
after errors registering the second one.
next prev parent reply other threads:[~2006-04-10 19:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 22:26 compile error when building multiple EHCI host controllers as modules Kumar Gala
2006-03-24 6:33 ` [linux-usb-devel] " David Brownell
2006-03-24 16:59 ` Kumar Gala
2006-03-24 20:32 ` Kumar Gala
2006-03-28 16:18 ` Kumar Gala
2006-03-28 17:51 ` Matthieu CASTET
2006-04-04 2:48 ` [linux-usb-devel] " David Brownell
2006-04-04 4:23 ` Kumar Gala
2006-04-05 17:32 ` Kumar Gala
2006-04-10 19:11 ` David Brownell [this message]
2006-04-10 19:16 ` Kumar Gala
2006-04-11 15:07 ` [PATCH] usb: allow multiple types of EHCI controllers to be built " Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604101211.23871.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=galak@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox