From: Oleg Nesterov <oleg@tv-sign.ru>
To: Roland McGrath <roland@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@elte.hu>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Andrew Morton <akpm@osdl.org>, Lee Revell <rlrevell@joe-job.com>
Subject: Re: [PATCH rc1-mm 2/3] coredump: shutdown current process first
Date: Mon, 10 Apr 2006 18:01:31 +0400 [thread overview]
Message-ID: <20060410140131.GB85@oleg> (raw)
In-Reply-To: <20060410070840.26AE41809D1@magilla.sf.frob.com>
On 04/10, Roland McGrath wrote:
>
> I would be inclined to restructure the inner loop something like this:
>
> p = g;
> while (unlikely(p->mm == NULL)) {
> p = next_thread(p);
> if (p == g)
> break;
> }
> if (p->mm == mm) {
> /*
> * p->sighand can't disappear, but
> * may be changed by de_thread()
> */
> lock_task_sighand(p, &flags);
> zap_process(p);
> unlock_task_sighand(p, &flags);
> }
Yes, I agree, this is much more understandable.
Oleg.
next prev parent reply other threads:[~2006-04-10 10:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-09 0:11 [PATCH rc1-mm 2/3] coredump: shutdown current process first Oleg Nesterov
2006-04-10 7:08 ` Roland McGrath
2006-04-10 14:01 ` Oleg Nesterov [this message]
2006-04-14 8:04 ` Eric W. Biederman
2006-04-14 15:33 ` Oleg Nesterov
2006-04-14 17:02 ` Eric W. Biederman
2006-06-09 17:24 ` [PATCH] 2.6.17-rc4 bugfix with initramfs Nickolay
2006-06-10 7:07 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060410140131.GB85@oleg \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=rlrevell@joe-job.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox