From: Sam Ravnborg <sam@ravnborg.org>
To: "linux-os (Dick Johnson)" <linux-os@analogic.com>
Cc: Adrian Bunk <bunk@stusta.de>, Aubrey <aubreylee@gmail.com>,
Erik Mouw <erik@harddisk-recovery.com>,
linux-kernel@vger.kernel.org
Subject: Re: The assemble file under the driver folder can not be recognized when the driver is built as module
Date: Mon, 10 Apr 2006 21:30:24 +0200 [thread overview]
Message-ID: <20060410193024.GA11292@mars.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0604101506430.26625@chaos.analogic.com>
On Mon, Apr 10, 2006 at 03:12:55PM -0400, linux-os (Dick Johnson) wrote:
>
> On Mon, 10 Apr 2006, Sam Ravnborg wrote:
>
> > On Mon, Apr 10, 2006 at 02:04:59PM -0400, linux-os (Dick Johnson) wrote:
> >
> >> Can't he just put his own private compile definition in his
> >> own Makefile?
> >>
> >> %.o: %.S
> >> as -o $@ $<
> >
> > That would never generate a module anyway. And kbuild support building
> > .o from .S with all the kbuild argument chechking etc.
> > Doing it so would be wrong.
> >
> > Sam
> >
>
>
> Really?? Here is a Makefile that has been known to work for sometime.
> As you can clearly see, it has lots of ".S" files. The last compile
> was on Linux-2.6.15.4. If current kernel building procedures prevents
> the assembly of assembly-language files and requires that the kernel
> modules be written entirely in 'C', then it is broken beyond all
> belief and must be fixed.
kbuild does not support a single-file module being written entirely in
assembler.
kbuild obviously support multi file modules where one file is in
assembler.
In your example you generate a multi file module where some files are in
assembler - supported.
And the point was that one should NOT define private rules like:
%.o: %.S
as -o $@ $<
If there is a valid need for such stuff - then kbuild needs to be fixed.
But I have yet to see a need like this.
I know several external modules plays all sort of tricks to avoid using
kbuild infrastructure - I recall you have posted such receipts before.
Recently posted loop-aes is another example (if USE_KBUILD is not set).
Sam
next prev parent reply other threads:[~2006-04-10 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 10:16 The assemble file under the driver folder can not be recognized when the driver is built as module Aubrey
2006-04-10 11:28 ` Erik Mouw
2006-04-10 13:27 ` Aubrey
2006-04-10 17:33 ` Sam Ravnborg
2006-04-10 17:42 ` Adrian Bunk
2006-04-10 18:04 ` linux-os (Dick Johnson)
2006-04-10 18:24 ` Sam Ravnborg
2006-04-10 19:12 ` linux-os (Dick Johnson)
2006-04-10 19:30 ` Sam Ravnborg [this message]
2006-04-11 2:58 ` Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060410193024.GA11292@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=aubreylee@gmail.com \
--cc=bunk@stusta.de \
--cc=erik@harddisk-recovery.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox