public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] de_thread: Don't confuse users do_each_thread.
Date: Tue, 11 Apr 2006 14:05:27 +0400	[thread overview]
Message-ID: <20060411100527.GA112@oleg> (raw)
In-Reply-To: <m1u091dnry.fsf@ebiederm.dsl.xmission.com>

On 04/10, Eric W. Biederman wrote:
>
> I believe this is 2.6.17 material as the bug is present in
> 2.6.17-rc1 and the fix is simple.
>
> ...
>
> +		list_del_init(&leader->tasks);

I beleive this is ok for 2.6.17-rc1, but this breaks lockless
for_each_process/while_each_thread (I am talking about -mm tree).

Andrew, could you please drop these ones:

	task-make-task-list-manipulations-rcu-safe-fix.patch
	task-make-task-list-manipulations-rcu-safe-fix-fix.patch

Then we need this "patch" for de_thread:

-		list_add_tail_rcu(&current->tasks, &init_task.tasks);
+		list_replace_rcu(&leader->tasks, &current->tasks);
 ...
-		list_del_init(&leader->tasks);

Currently I don't know how the code looks in -mm tree, I lost the plot.

Oleg.


  parent reply	other threads:[~2006-04-11  6:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-06 22:04 [PATCH rc1-mm] de_thread: fix deadlockable process addition Oleg Nesterov
2006-04-06 22:58 ` Eric W. Biederman
2006-04-07 23:46   ` Oleg Nesterov
2006-04-07 22:51     ` Andrew Morton
2006-04-07 22:56       ` Andrew Morton
2006-04-08  7:55         ` Eric W. Biederman
2006-04-08 17:27           ` Oleg Nesterov
2006-04-08 16:07             ` Eric W. Biederman
2006-04-08 21:13               ` Oleg Nesterov
2006-04-08 21:23                 ` Oleg Nesterov
2006-04-10 22:11                   ` Eric W. Biederman
2006-04-10 23:07             ` [PATCH] de_thread: Don't confuse users do_each_thread Eric W. Biederman
2006-04-10 23:16               ` Eric W. Biederman
2006-04-10 23:52                 ` Ingo Oeser
2006-04-11  6:18                   ` Eric W. Biederman
2006-04-11 10:19                   ` Oleg Nesterov
2006-04-11  7:25                     ` Ingo Oeser
2006-04-11  7:36                       ` Eric W. Biederman
2006-04-11 19:50                         ` Ingo Oeser
2006-04-11 10:05                 ` Oleg Nesterov [this message]
2006-04-11  5:23                   ` Andrew Morton
2006-04-11 10:47                     ` Oleg Nesterov
2006-04-11  6:23                   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060411100527.GA112@oleg \
    --to=oleg@tv-sign.ru \
    --cc=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox