public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: Binary sysfs blobs
Date: Tue, 11 Apr 2006 11:57:25 -0700	[thread overview]
Message-ID: <200604111157.25885.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20060411110841.71390306.zaitcev@redhat.com>

On Tuesday, April 11, 2006 11:08 am, Pete Zaitcev wrote:
> Hi, Greg:
>
> I was reviewing some patches here and noticed (yes, only now noticed)
> that we have operations on binary blobs in fs/sysfs/bin.c. I thought
> it wasn't part of the deal for sysfs, with one value per file and so
> on. I suppose it's too late to debate now, but I have a couple of
> questions:
>
>  - Do you know of any conventions which allow to determine which file
>    is binary? Maybe the name starting with an underscore or something?

AFAIK there isn't any convention.  The PCI related files 
(/sys/bus/pci/devices/...) don't have a particular naming scheme for 
example.

>  - Is there a standing policy that reading from a sysfs file is not
>    altering a state of the corresponding hardware? This is not related
>    to blobs directly, but with people passing structs now, it's
> tempting to implement some extended protocols. I am concerned of
> stealing network packets by accident or something.

Nope, again if you access the PCI files you may end up programming the 
hardware in some way.  There may be other examples of this elsewhere, 
but I haven't looked.

Jesse

  reply	other threads:[~2006-04-11 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11 18:08 Binary sysfs blobs Pete Zaitcev
2006-04-11 18:57 ` Jesse Barnes [this message]
2006-04-11 20:42 ` Greg KH
2006-04-12 10:34   ` Pete Zaitcev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604111157.25885.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox