From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kernel/rcupdate.c: kill synchronize_kernel()
Date: Tue, 11 Apr 2006 07:35:31 -0700 [thread overview]
Message-ID: <20060411143531.GA1295@us.ibm.com> (raw)
In-Reply-To: <20060411035100.GD3190@stusta.de>
Hello, Adrian,
This one is on my list for May 1st. At that time, I will submit a
patch such that:
o synchronize_kernel() goes away
o call_rcu() and call_rcu_bh() become EXPORT_SYMBOL_GPL().
Thanx, Paul
On Tue, Apr 11, 2006 at 05:51:01AM +0200, Adrian Bunk wrote:
> synchronize_kernel() is both deprecated and completely unused.
>
> Let's kill this bloat.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> Documentation/RCU/whatisRCU.txt | 1 -
> include/linux/rcupdate.h | 1 -
> kernel/rcupdate.c | 9 ---------
> 3 files changed, 11 deletions(-)
>
> --- linux-2.6.17-rc1-mm2-full/Documentation/RCU/whatisRCU.txt.old 2006-04-11 01:23:39.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-full/Documentation/RCU/whatisRCU.txt 2006-04-11 01:23:45.000000000 +0200
> @@ -790,7 +790,6 @@
>
> RCU grace period:
>
> - synchronize_kernel (deprecated)
> synchronize_net
> synchronize_sched
> synchronize_rcu
> --- linux-2.6.17-rc1-mm2-full/include/linux/rcupdate.h.old 2006-04-11 01:23:53.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-full/include/linux/rcupdate.h 2006-04-11 01:24:28.000000000 +0200
> @@ -263,7 +263,6 @@
> void (*func)(struct rcu_head *head)));
> extern void FASTCALL(call_rcu_bh(struct rcu_head *head,
> void (*func)(struct rcu_head *head)));
> -extern __deprecated_for_modules void synchronize_kernel(void);
> extern void synchronize_rcu(void);
> void synchronize_idle(void);
> extern void rcu_barrier(void);
> --- linux-2.6.17-rc1-mm2-full/kernel/rcupdate.c.old 2006-04-11 01:24:36.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-full/kernel/rcupdate.c 2006-04-11 01:24:57.000000000 +0200
> @@ -593,14 +593,6 @@
> wait_for_completion(&rcu.completion);
> }
>
> -/*
> - * Deprecated, use synchronize_rcu() or synchronize_sched() instead.
> - */
> -void synchronize_kernel(void)
> -{
> - synchronize_rcu();
> -}
> -
> module_param(blimit, int, 0);
> module_param(qhimark, int, 0);
> module_param(qlowmark, int, 0);
> @@ -611,4 +603,3 @@
> EXPORT_SYMBOL_GPL_FUTURE(call_rcu); /* WARNING: GPL-only in April 2006. */
> EXPORT_SYMBOL_GPL_FUTURE(call_rcu_bh); /* WARNING: GPL-only in April 2006. */
> EXPORT_SYMBOL_GPL(synchronize_rcu);
> -EXPORT_SYMBOL_GPL_FUTURE(synchronize_kernel); /* WARNING: GPL-only in April 2006. */
>
next prev parent reply other threads:[~2006-04-11 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 3:51 [2.6 patch] kernel/rcupdate.c: kill synchronize_kernel() Adrian Bunk
2006-04-11 14:35 ` Paul E. McKenney [this message]
2006-04-11 14:53 ` Andreas Mohr
2006-04-11 15:12 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411143531.GA1295@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox