public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] __group_complete_signal: remove bogus BUG_ON
@ 2006-04-11 18:18 Oleg Nesterov
  0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2006-04-11 18:18 UTC (permalink / raw)
  To: linux-kernel
  Cc: Roland McGrath, Eric W. Biederman, Ingo Molnar, Paul E. McKenney,
	Linus Torvalds, Andrew Morton

Commit	e56d090310d7625ecb43a1eeebd479f04affb48b
[PATCH] RCU signal handling

made this BUG_ON() unsafe. This code runs under ->siglock,
while switch_exec_pids() takes tasklist_lock.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 2.6.16/kernel/signal.c~	2006-02-13 21:47:19.000000000 +0300
+++ 2.6.16/kernel/signal.c	2006-04-11 21:53:03.000000000 +0400
@@ -975,7 +975,6 @@ __group_complete_signal(int sig, struct 
 		if (t == NULL)
 			/* restart balancing at this thread */
 			t = p->signal->curr_target = p;
-		BUG_ON(t->tgid != p->tgid);
 
 		while (!wants_signal(sig, t)) {
 			t = next_thread(t);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-04-11 14:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-11 18:18 [PATCH] __group_complete_signal: remove bogus BUG_ON Oleg Nesterov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox