From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix block device symlink name
Date: Tue, 11 Apr 2006 22:08:07 +1000 [thread overview]
Message-ID: <20060411220807.357e253d@localhost> (raw)
In-Reply-To: <Pine.LNX.4.61.0604111337450.928@yvahk01.tjqt.qr>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Tue, 11 Apr 2006 13:38:09 +0200 (MEST) Jan Engelhardt <jengelh@linux01.gwdg.de> wrote:
>
> >@@ -352,6 +353,10 @@ static char *make_block_name(struct gend
> > return NULL;
> > strcpy(name, block_str);
> > strcat(name, disk->disk_name);
> >+ /* ewww... some of these buggers have / in name... */
> >+ s = strchr(name, '/');
> >+ if (s)
> >+ *s = '!';
> > return name;
> > }
> >
>
> Can they have multiple '/'? If so, we need a while loop.
The other place that fixes this (just 10 or so lines further on in this
file) does not loop. Looking through the block devices, there is no
obvious place that creates a name with more than one '/'.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-04-11 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 5:16 [PATCH] Fix block device symlink name Stephen Rothwell
2006-04-11 11:38 ` Jan Engelhardt
2006-04-11 12:08 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411220807.357e253d@localhost \
--to=sfr@canb.auug.org.au \
--cc=gregkh@suse.de \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox