From: Ingo Oeser <ioe-lkml@rameria.de>
To: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
TPM Device Driver List <tpmdd-devel@lists.sourceforge.net>
Subject: Re: [PATCH] tpm: sysfs function buffer size fix
Date: Tue, 11 Apr 2006 22:45:01 +0200 [thread overview]
Message-ID: <200604112245.02443.ioe-lkml@rameria.de> (raw)
In-Reply-To: <1144786558.12054.14.camel@localhost.localdomain>
Hi Kylene,
On Tuesday, 11. April 2006 22:15, Kylene Jo Hall wrote:
> --- linux-2.6.17-rc1-mm2/drivers/char/tpm/tpm.c 2006-04-11 14:56:13.311776750 -0500
> +++ linux-2.6.17-rc1/drivers/char/tpm/tpm.c 2006-04-11 15:03:29.427032250 -0500
> @@ -490,7 +490,7 @@ static ssize_t transmit_cmd(struct tpm_c
>
> void tpm_gen_interrupt(struct tpm_chip *chip)
> {
> - u8 data[30];
> + u8 data[max(ARRAY_SIZE(tpm_cap), 30)];
> ssize_t rc;
>
> memcpy(data, tpm_cap, sizeof(tpm_cap));
> @@ -504,7 +504,7 @@ EXPORT_SYMBOL_GPL(tpm_gen_interrupt);
>
> void tpm_get_timeouts(struct tpm_chip *chip)
> {
> - u8 data[30];
> + u8 data[max(ARRAY_SIZE(TPM_CAP), 30)];
> ssize_t rc;
> u32 timeout;
>
Once in ALL CAPS and once in lower case?
Sure about these?
Regards
Ingo Oeser
next prev parent reply other threads:[~2006-04-11 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 14:37 [PATCH 2/7] tpm: reorganize sysfs files - Updated patch Kylene Jo Hall
2006-04-10 21:46 ` Andrew Morton
2006-04-11 14:24 ` Kylene Jo Hall
2006-04-11 18:18 ` Andrew Morton
2006-04-11 20:15 ` [PATCH] tpm: sysfs function buffer size fix Kylene Jo Hall
2006-04-11 20:45 ` Ingo Oeser [this message]
2006-04-11 21:05 ` Kylene Jo Hall
2006-04-11 22:32 ` [PATCH] tpm: compiler cleanup Kylene Jo Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604112245.02443.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=akpm@osdl.org \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox