Re: [RFC] Patch to fix cdrom being confused on using kdump

Jens Axboe
2006-04-19T13:52:20Z

On Wed, Apr 19 2006, Rachita Kothiyal wrote:
> On Wed, Apr 12, 2006 at 04:59:33PM +0530, Rachita Kothiyal wrote:
> >
> > I actually tried just reading the status register and then returning
> > ide_stopped. It seemed to be working fine, just that there appears
> > a 'status error' message while booting:
> >
> > <snippet>
> > ide0: start_request: current=0xffff8100035cba68
> > hda: status error: status=0x58 { DriveReady SeekComplete DataRequest }
> > ide: failed opcode was: unknown
> > hda: drive not ready for command
> > </snippet>
>
> Hi Jens,
>
> Instead of reading the status register and returning ide_stopped
> from the handler, which was resulting in the 'status error', I
> tried ending the request and returning ide_stopped when the drive
> is in a confused state. Using this I dont see the status error.
>
> Following is the patch, kindly review.

This looks a lot more appropriate! Thanks for following through on this.

--
Jens Axboe